New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IDNSZoneResolver interfaceId does not match tests #112

Open

storywithoutend opened this issue Jul 28, 2022 · 0 comments

storywithoutend commented Jul 28, 2022

In /test/resolvers/TestPublicResolver.js the interfaceId for IDNSZoneResolver is '0x5c98042b'

  assert.equal(await resolver.supportsInterface('0x5c98042b'), true) // IDNSZoneResolver

But in /deployments/mainnet/solcInputs, the interfaceId is '0x5c47637c'

DNS_ZONE_INTERFACE_ID = 0x5c47637c;

Also when checking if the resolver contract supports the interface the following addresses fail for both '0x5c98042b' and '0x5c47637c'

'0x4976fb03C32e5B8cfe2b6cCB31c09Ba78EBaBa41'
'0xdaaf96c344f63131acadd0ea35170e7892d3dfba'
'0x226159d592e2b063810a10ebf6dcbada94ed68b8'
'0x1da022710df5002339274aadee8d58218e9d6ab5'

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment