Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include vptstools version number in docker #72

Open
peterdesmet opened this issue Jan 22, 2024 · 1 comment
Open

Include vptstools version number in docker #72

peterdesmet opened this issue Jan 22, 2024 · 1 comment

Comments

@peterdesmet
Copy link
Member

@stijnvanhoey in the call we discovered that the ECS revisions always have latest in their tag. I think that is defined in the release.yml in this repository though:

tags: ${{ steps.login-ecr.outputs.registry }}/inbo-aloft:latest

Would you know how to change this to include the version number of vptstools?

@stijnvanhoey
Copy link
Collaborator

stijnvanhoey commented Jan 22, 2024

I would keep the 'latest' and add a second tag with the git-tag.

I would try with using ${{ github.event.release.tag_name }} (tag related to the event that triggered the release github actions) or - if that does not work - github.ref from the github context, see https://docs.github.com/en/actions/learn-github-actions/contexts#github-context.

I would expect something like this should work:

...
tags: ${{ steps.login-ecr.outputs.registry }}/inbo-aloft:latest, ${{ steps.login-ecr.outputs.registry }}/inbo-aloft:${{ github.event.release.tag_name }}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants