Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide environment in exception messages #67

Open
peterdesmet opened this issue Aug 28, 2023 · 1 comment
Open

Provide environment in exception messages #67

peterdesmet opened this issue Aug 28, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@peterdesmet
Copy link
Member

Suggestion by @TheJenne18 to avoid confusion from what environment notifications are send (#62), it might be useful to provide the os.environment("ENV") in error messages such as:

CLI routine 'vph5_to_vpts --modified-days-ago 2' failed raising error: '<class 'ValueError'>: File name uva/hdf5/dbl/2008/02/17/nldbl_vp_20080217t0000_nl50_v0-3-20.h5 is not a valid ODIM HDF5 file.'.
@peterdesmet peterdesmet added the enhancement New feature or request label Aug 28, 2023
@TheJenne18
Copy link
Contributor

We currently don't have an environment variable to determine whether the application is in PROD, UAT, or DEV, so we need to create one called 'ENV'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@peterdesmet @TheJenne18