Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ONS introduces illegal punning on properties #33

Open
matentzn opened this issue May 4, 2022 · 7 comments
Open

ONS introduces illegal punning on properties #33

matentzn opened this issue May 4, 2022 · 7 comments

Comments

@matentzn
Copy link

matentzn commented May 4, 2022

According to the OWL specification an property can never be an annotation and an object property at the same time.

robot merge -I http://purl.obolibrary.org/obo/ons.owl -I http://purl.obolibrary.org/obo/ro.owl validate-profile --profile DL

Cannot pun between properties: <http://purl.obolibrary.org/obo/RO_0002434
Cannot pun between properties: <http://purl.obolibrary.org/obo/RO_0000052
Cannot pun between properties: <http://purl.obolibrary.org/obo/RO_0002018
Cannot pun between properties: <http://purl.obolibrary.org/obo/RO_0002233
Cannot pun between properties: <http://purl.obolibrary.org/obo/RO_0002248
Cannot pun between properties: <http://purl.obolibrary.org/obo/RO_0002434
Cannot pun between properties: <http://purl.obolibrary.org/obo/RO_0002437
Cannot pun between properties: <http://purl.obolibrary.org/obo/RO_0002501
Cannot pun between properties: <http://purl.obolibrary.org/obo/RO_0002506
Cannot pun between properties: <http://purl.obolibrary.org/obo/RO_0002507
Cannot pun between properties: <http://purl.obolibrary.org/obo/RO_0002509
Cannot pun between properties: <http://purl.obolibrary.org/obo/RO_0002574
Cannot pun between properties: <http://purl.obolibrary.org/obo/RO_0002595

Furthermore, you are using an illegal restriction, probably imported from ERO:

Use of non-simple property in a restriction: ObjectExactCardinality(0 <http://purl.obolibrary.org/obo/BFO_0000051> <http://purl.obolibrary.org/obo/ERO_0000347>) [SubClassOf(<http://purl.obolibrary.org/obo/ONS_0000083> ObjectExactCardinality(0 <http://purl.obolibrary.org/obo/BFO_0000051> <http://purl.obolibrary.org/obo/ERO_0000347>)) in OntologyID(OntologyIRI(<https://raw.githubusercontent.com/enpadasi/Ontology-for-Nutritional-Studies/master/ons.owl>) VersionIRI(<null>))]

It is very important to fix this, as this severely hampers integration with ONS for ontologies such as ECTO: I basically have to forcefully delete dozens of axioms from ONS before being able to merge it in.

@ddooley
Copy link
Contributor

ddooley commented May 9, 2022

@FrancescoVit similarly, do you need a hand to address this?

@FrancescoVit
Copy link
Member

FrancescoVit commented May 10, 2022

@matentzn I'll likely manually remove the duplicates annotation properties, but I am trying to figure out if the problem comes from the main file, or from the various import. Try to fix as soon as possible

@ddooley thank you very much, I hope to be able to figure out the problem and fix it, but will gladly accept the help if i should fail :D

FrancescoVit added a commit that referenced this issue May 13, 2022
Commenting the annotation properties also removed the object properties annotations; in this commit RO properties listed as "AnnotationProperty" were changed to "ObjectProperty", then removing duplicates
@FrancescoVit
Copy link
Member

should be fixed now, still have the problem of multiple labels as in #15 and #34

@dillerm
Copy link

dillerm commented Jun 30, 2022

I'm currently seeing this issue for http://purl.obolibrary.org/obo/RO_0001900, but not for the others listed.

@matentzn
Copy link
Author

Did you try:

robot merge -I http://purl.obolibrary.org/obo/ons.owl -I http://purl.obolibrary.org/obo/ro.owl validate-profile --profile DL

@dillerm
Copy link

dillerm commented Jun 30, 2022

No, this was flagged by HermiT when I ran the reasoner.

@ddooley
Copy link
Contributor

ddooley commented May 23, 2024

Hermit runs fine on /src/ontology/ons-edit.ofn so I think we can close this. It will work with next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants