Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforcing black for python code formatting #44

Open
Lakshmikanth2001 opened this issue Feb 24, 2022 · 4 comments
Open

Enforcing black for python code formatting #44

Lakshmikanth2001 opened this issue Feb 24, 2022 · 4 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@Lakshmikanth2001
Copy link
Contributor

021cfe7 Sir as our code base is growing in size i want a uniform python code format across all our modules please review it and give your valuable feed bak

@engineerjoe440
Copy link
Owner

I'm hesitant with black formatting. I know it's the standard, but there are so many formatting rules that I don't agree with. I've reviewed your PR, and you've managed to make it look VERY good overall. There's a handful of things that the black formatter seems to have gone "too far" with; however, if we're able to get those pieces under control, I think it'll be worth updating. If we're unable to get those pieces, I think it'll be enough to stick with pylint (which is my preference).

@Lakshmikanth2001
Copy link
Contributor Author

Black is a PEP 8 compliant opinionated formatter with format whereas pylint is a code linter

  • pylint just informs where the errors might occur, import optimization, suggest code style
  • black will format your code insted

@engineerjoe440 engineerjoe440 added enhancement New feature or request help wanted Extra attention is needed labels May 6, 2022
@engineerjoe440 engineerjoe440 added this to the Next Version: v0.3.0 milestone May 6, 2022
@engineerjoe440
Copy link
Owner

engineerjoe440 commented May 6, 2022

I've sat on this and been slow; which reflects poorly on me as a maintainer. I want to say though, I've come around to agree with you completely. Not only should we make this repo Black compliant. I think we NEED to have Black compliance in the repo.

I'm definitely onboard! :) Thank you for your persistence, and your patience! 😄

@engineerjoe440 engineerjoe440 removed this from the Next Version: v0.3.0 milestone Aug 28, 2022
@engineerjoe440
Copy link
Owner

Removing milestone association since this isn't ready to "roll" yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants