You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the Dinosaur Planet decomp we have DLL code that makes heavy use of static functions which must be static in order to match calling code. These are missing from objdiff as it ignores local symbols with a size of zero: https://github.com/encounter/objdiff/blob/main/objdiff-core/src/obj/read.rs#L170-L176. Removing this code fixes the issue but I imagine also breaks other projects.
I don't totally understand why these symbols have a size of zero but if it helps the compiler is IDO 5.3.
In the Dinosaur Planet decomp we have DLL code that makes heavy use of static functions which must be static in order to match calling code. These are missing from objdiff as it ignores local symbols with a size of zero: https://github.com/encounter/objdiff/blob/main/objdiff-core/src/obj/read.rs#L170-L176. Removing this code fixes the issue but I imagine also breaks other projects.
I don't totally understand why these symbols have a size of zero but if it helps the compiler is IDO 5.3.
readelf
symbol table output(num, value, size, type, bind, vis, ndx, name):
Missing functions in UI (CLI can't diff them either, just says it cant find the symbol):
![Image](https://private-user-images.githubusercontent.com/6609531/404698129-4cff07b9-39aa-431b-80ca-09354b0cf266.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg4MzY5NjksIm5iZiI6MTczODgzNjY2OSwicGF0aCI6Ii82NjA5NTMxLzQwNDY5ODEyOS00Y2ZmMDdiOS0zOWFhLTQzMWItODBjYS0wOTM1NGIwY2YyNjYucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIwNiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMDZUMTAxMTA5WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NTgwMTMyMTllYjMwMTdiOTc5OGMyYmQ4ZjBiMGIwMDI1OGE1MDNmODY3YmRiNTAxYjg3ZDJhOTFhZTBiNDE3ZSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.7XKpHMpQ-ItCKBG0MNM7CJ2-cy2lHwY75hqBL0tip_o)
The text was updated successfully, but these errors were encountered: