Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local static functions are missing from diff #156

Open
Francessco121 opened this issue Jan 19, 2025 · 0 comments
Open

Local static functions are missing from diff #156

Francessco121 opened this issue Jan 19, 2025 · 0 comments

Comments

@Francessco121
Copy link

In the Dinosaur Planet decomp we have DLL code that makes heavy use of static functions which must be static in order to match calling code. These are missing from objdiff as it ignores local symbols with a size of zero: https://github.com/encounter/objdiff/blob/main/objdiff-core/src/obj/read.rs#L170-L176. Removing this code fixes the issue but I imagine also breaks other projects.

I don't totally understand why these symbols have a size of zero but if it helps the compiler is IDO 5.3.

readelf symbol table output
(num, value, size, type, bind, vis, ndx, name):
Image

Missing functions in UI (CLI can't diff them either, just says it cant find the symbol):
Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant