Fix Github Workflows #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DomBlack
force-pushed
the
fix-github-workflows
branch
19 times, most recently
from
1976b11 to
fa948fe
Compare
This commit fixes the Github workflows to work with the new system
DomBlack
force-pushed
the
fix-github-workflows
branch
from
fa948fe to
616a063
Compare
DomBlack
commented
Jan 25, 2022
| # This step gets the exact version of Go we're releasing (including minor), so if we give the input as `1.17` this might return `encore-go1.17.5`. | ||
| - name: 'Read the version of Go we built' | ||
| id: encore_go_version | ||
| run: echo "::set-output name=version::$(go run . --read-built-version)" |
There was a problem hiding this comment.
Note; I did this via the main.go file so it works on Windows as well as MacOS & Linux (and doesn't need us to write separate powershell code vs bash code)
DomBlack
commented
Jan 25, 2022
| cat checksums.txt | ||
|
|
||
| - name: 'Publish release' | ||
| uses: DomBlack/[email protected] |
There was a problem hiding this comment.
I created a fork of meeDamian/github-release and applied this PR which fixes a SSL reset issue with the current main release.
DomBlack
commented
Jan 25, 2022
| run: | | ||
| cd ${{needs.build.outputs.built_version}}-windows_amd64 | ||
| tar -xzf ${{needs.build.outputs.built_version}}-windows_amd64.tar.gz | ||
| zip -r ${{needs.build.outputs.built_version}}-windows_amd64.zip encore-go |
There was a problem hiding this comment.
I created a zip version just to be nicer to Windows users who might not be used to working with tar.gz files
DomBlack
commented
Jan 25, 2022
| allow_override: true | ||
| prerelease: ${{ github.event.inputs.prerelease }} | ||
| gzip: false | ||
| files: Linux_x86-64.tar.gz Windows_x86-64.tar.gz Windows_x86-64.zip macOS_arm64.tar.gz macOS_x86-64.tar.gz checksums.txt |
There was a problem hiding this comment.
I went with these file names rather than the Go ARCH names so it's harder to mistakenly get an AMD64 vs ARM64 build.
eandre
approved these changes
Jan 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the Github workflows since the refactor of this project. The updated workflows now also creates Github releases. For example this call to the workflow resulted in this release. It was given the version parameter of
1.17and it downloaded the latest Go 1.17.x release; patched it; and released it on this repo.This PR also adds more descriptions to the patch files to explain what each patch file is doing