Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[democracy] Nay votes shouldn't start Confirming phase #407

Closed
brenzi opened this issue Dec 2, 2024 · 2 comments
Closed

[democracy] Nay votes shouldn't start Confirming phase #407

brenzi opened this issue Dec 2, 2024 · 2 comments
Assignees
@clangenb

Comments

@brenzi
Copy link
Member

brenzi commented Dec 2, 2024

voting Nay as the first voter (1/17) currently can trigger confirmation phase. this is not ideal as the default is dismissal anyway
@brenzi
Copy link
Member Author

brenzi commented Dec 20, 2024

not sure this still applies. this may have been caused by other bug

@brenzi
Copy link
Member Author

brenzi commented Jan 15, 2025

do_update_proposal_state is called in any case. Only if the proposal is passing after counting the newest vote can the state change to confirming. This issue is likely as misinterpretation of the UI and is likely already fixed in the UI

@brenzi brenzi closed this as completed Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@clangenb clangenb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brenzi @clangenb