LocalProtocolError when handshake_complete is made to False

[iudeen]

When I simulate handshake_complete to be false in Websockets implementation (using wsproto), it runs into LocalProtocolError and the InternalServerError message sent by Uvicorn is not sent at all.

I dug a little into it and found this piece of code:

    # wsproto_impl.py line: 199
    def send_500_response(self):
        headers = [
            (b"content-type", b"text/plain; charset=utf-8"),
            (b"connection", b"close"),
        ]
        if self.conn.connection is None:
            output = self.conn.send(wsproto.events.RejectConnection(status_code=500))
        else:
            msg = h11.Response(
                status_code=500, headers=headers, reason="Internal Server Error"
            )
            output = self.conn.send(msg)
            msg = h11.Data(data=b"Internal Server Error")
            output += self.conn.send(msg)
            msg = h11.EndOfMessage()
            output += self.conn.send(msg)
        self.transport.write(output)

While wsproto expects type Event, h11.Response is being sent.

I am not sure if this is an issue. I noticed this strange behavior when I was testing a few things. Please feel free to close if its not relevant.

[iudeen]

I checked implementation on a higher level in Hypercorn's implementation. H1 request or response are not sent, it's only Events that are sent to ws-Porto

I'll do a line by line debug and try to replicate similar scenario soon.