`other.test_split_module` regression

[juj]

C:\emsdk\emscripten\main>test\runner other.test_split_module
Running 1 tests
[1/1] test_split_module (test_other.other.test_split_module) ... FAIL

Stdout:
-- begin program output --
C:\emsdk\emscripten\main\out\test\test_split_module.js:652
  var instance = new WebAssembly.Instance(module, info);
                 ^

LinkError: WebAssembly.Instance(): table import 9 has a larger maximum size 14 than the module's declared maximum 8
    at instantiateSync (C:\emsdk\emscripten\main\out\test\test_split_module.js:652:18)
    at ret (C:\emsdk\emscripten\main\out\test\test_split_module.js:637:13)
    at test_split_module.wasm.trampoline_say_hello (wasm://wasm/test_split_module.wasm-0007ecf6:wasm-function[30]:0x17b0)
    at C:\emsdk\emscripten\main\out\test\test_split_module.js:583:12
    at saveProfileData (C:\emsdk\emscripten\main\out\test\test_split_module.js:1764:16)
    at callRuntimeCallbacks (C:\emsdk\emscripten\main\out\test\test_split_module.js:818:26)
    at postRun (C:\emsdk\emscripten\main\out\test\test_split_module.js:520:3)
    at doRun (C:\emsdk\emscripten\main\out\test\test_split_module.js:1682:5)
    at run (C:\emsdk\emscripten\main\out\test\test_split_module.js:1693:5)
    at removeRunDependency (C:\emsdk\emscripten\main\out\test\test_split_module.js:852:11)
    at receiveInstance (C:\emsdk\emscripten\main\out\test\test_split_module.js:725:5)
    at receiveInstantiationResult (C:\emsdk\emscripten\main\out\test\test_split_module.js:742:12)
    at createWasm (C:\emsdk\emscripten\main\out\test\test_split_module.js:768:17)
Thrown at:
    at instantiateSync (C:\emsdk\emscripten\main\out\test\test_split_module.js:652:18)
    at ret (C:\emsdk\emscripten\main\out\test\test_split_module.js:637:13)
    at $trampoline_say_hello (wasm://wasm/test_split_module.wasm-0007ecf6:1:6065)
    at C:\emsdk\emscripten\main\out\test\test_split_module.js:583:12
    at saveProfileData (C:\emsdk\emscripten\main\out\test\test_split_module.js:1764:16)
    at callRuntimeCallbacks (C:\emsdk\emscripten\main\out\test\test_split_module.js:818:26)
    at postRun (C:\emsdk\emscripten\main\out\test\test_split_module.js:520:3)
    at doRun (C:\emsdk\emscripten\main\out\test\test_split_module.js:1682:5)
    at run (C:\emsdk\emscripten\main\out\test\test_split_module.js:1693:5)
    at removeRunDependency (C:\emsdk\emscripten\main\out\test\test_split_module.js:852:11)


Node.js v22.16.0
-- end program output --


======================================================================
FAIL: test_split_module (test_other.other.test_split_module)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "C:\emsdk\emscripten\main\test\common.py", line 380, in resulting_test
    return func(self, *args)
  File "C:\emsdk\emscripten\main\test\decorators.py", line 419, in metafunc
    return func(self, *args, **kwargs)
  File "C:\emsdk\emscripten\main\test\test_other.py", line 12476, in test_split_module
    result = self.run_js('test_split_module.js')
  File "C:\emsdk\emscripten\main\test\common.py", line 1025, in run_js
    self.fail('JS subprocess failed (%s): %s (expected=%s).  Output:\n%s' % (error.cmd, error.returncode, assert_returncode, ret))
    ~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: JS subprocess failed (C:/emsdk/node/22.16.0_64bit/bin/node.exe --stack-trace-limit=50 --trace-uncaught C:\emsdk\emscripten\main\out\test\test_split_module.js): 1 (expected=0).  Output:
C:\emsdk\emscripten\main\out\test\test_split_module.js:652
  var instance = new WebAssembly.Instance(module, info);
                 ^

LinkError: WebAssembly.Instance(): table import 9 has a larger maximum size 14 than the module's declared maximum 8
    at instantiateSync (C:\emsdk\emscripten\main\out\test\test_split_module.js:652:18)
    at ret (C:\emsdk\emscripten\main\out\test\test_split_module.js:637:13)
    at test_split_module.wasm.trampoline_say_hello (wasm://wasm/test_split_module.wasm-0007ecf6:wasm-function[30]:0x17b0)
    at C:\emsdk\emscripten\main\out\test\test_split_module.js:583:12
    at saveProfileData (C:\emsdk\emscripten\main\out\test\test_split_module.js:1764:16)
    at callRuntimeCallbacks (C:\emsdk\emscripten\main\out\test\test_split_module.js:818:26)
    at postRun (C:\emsdk\emscripten\main\out\test\test_split_module.js:520:3)
    at doRun (C:\emsdk\emscripten\main\out\test\test_split_module.js:1682:5)
    at run (C:\emsdk\emscripten\main\out\test\test_split_module.js:1693:5)
    at removeRunDependency (C:\emsdk\emscripten\main\out\test\test_split_module.js:852:11)
    at receiveInstance (C:\emsdk\emscripten\main\out\test\test_split_module.js:725:5)
    at receiveInstantiationResult (C:\emsdk\emscripten\main\out\test\test_split_module.js:742:12)
    at createWasm (C:\emsdk\emscripten\main\out\test\test_split_module.js:768:17)
Thrown at:
    at instantiateSync (C:\emsdk\emscripten\main\out\test\test_split_module.js:652:18)
    at ret (C:\emsdk\emscripten\main\out\test\test_split_module.js:637:13)
    at $trampoline_say_hello (wasm://wasm/test_split_module.wasm-0007ecf6:1:6065)
    at C:\emsdk\emscripten\main\out\test\test_split_module.js:583:12
    at saveProfileData (C:\emsdk\emscripten\main\out\test\test_split_module.js:1764:16)
    at callRuntimeCallbacks (C:\emsdk\emscripten\main\out\test\test_split_module.js:818:26)
    at postRun (C:\emsdk\emscripten\main\out\test\test_split_module.js:520:3)
    at doRun (C:\emsdk\emscripten\main\out\test\test_split_module.js:1682:5)
    at run (C:\emsdk\emscripten\main\out\test\test_split_module.js:1693:5)
    at removeRunDependency (C:\emsdk\emscripten\main\out\test\test_split_module.js:852:11)


Node.js v22.16.0


Stdout:
-- begin program output --
C:\emsdk\emscripten\main\out\test\test_split_module.js:652
  var instance = new WebAssembly.Instance(module, info);
                 ^

LinkError: WebAssembly.Instance(): table import 9 has a larger maximum size 14 than the module's declared maximum 8
    at instantiateSync (C:\emsdk\emscripten\main\out\test\test_split_module.js:652:18)
    at ret (C:\emsdk\emscripten\main\out\test\test_split_module.js:637:13)
    at test_split_module.wasm.trampoline_say_hello (wasm://wasm/test_split_module.wasm-0007ecf6:wasm-function[30]:0x17b0)
    at C:\emsdk\emscripten\main\out\test\test_split_module.js:583:12
    at saveProfileData (C:\emsdk\emscripten\main\out\test\test_split_module.js:1764:16)
    at callRuntimeCallbacks (C:\emsdk\emscripten\main\out\test\test_split_module.js:818:26)
    at postRun (C:\emsdk\emscripten\main\out\test\test_split_module.js:520:3)
    at doRun (C:\emsdk\emscripten\main\out\test\test_split_module.js:1682:5)
    at run (C:\emsdk\emscripten\main\out\test\test_split_module.js:1693:5)
    at removeRunDependency (C:\emsdk\emscripten\main\out\test\test_split_module.js:852:11)
    at receiveInstance (C:\emsdk\emscripten\main\out\test\test_split_module.js:725:5)
    at receiveInstantiationResult (C:\emsdk\emscripten\main\out\test\test_split_module.js:742:12)
    at createWasm (C:\emsdk\emscripten\main\out\test\test_split_module.js:768:17)
Thrown at:
    at instantiateSync (C:\emsdk\emscripten\main\out\test\test_split_module.js:652:18)
    at ret (C:\emsdk\emscripten\main\out\test\test_split_module.js:637:13)
    at $trampoline_say_hello (wasm://wasm/test_split_module.wasm-0007ecf6:1:6065)
    at C:\emsdk\emscripten\main\out\test\test_split_module.js:583:12
    at saveProfileData (C:\emsdk\emscripten\main\out\test\test_split_module.js:1764:16)
    at callRuntimeCallbacks (C:\emsdk\emscripten\main\out\test\test_split_module.js:818:26)
    at postRun (C:\emsdk\emscripten\main\out\test\test_split_module.js:520:3)
    at doRun (C:\emsdk\emscripten\main\out\test\test_split_module.js:1682:5)
    at run (C:\emsdk\emscripten\main\out\test\test_split_module.js:1693:5)
    at removeRunDependency (C:\emsdk\emscripten\main\out\test\test_split_module.js:852:11)


Node.js v22.16.0
-- end program output --

----------------------------------------------------------------------
Ran 1 test in 1.174s

FAILED (failures=1)

Similar to #26936, this test is failing, but only after updating to latest LLVM. Reproes on my CI on Linux, Windows and Mac.

Started about a day ago, see e.g. http://clbri.com:8010/#/builders/11

[sbc100]

It looks like the binaryen roller is currently failure for this issue: https://autoroll.skia.org/r/binaryen-emscripten-releases.

This means that emscripten-releases is effectively pinned at the revision prior to WebAssembly/binaryen#8688. @aheejin are you aware of this issue already?

@juj, maybe it would be worth syncing your CI builders to latest known-good revisions for llvm and binaryen? @dschuff IIRC you wrong a script somewhere that can easily pull the currently pinned revisions from the emscripten-releases repo?

[juj]

It looks like the binaryen roller is currently failure for this issue: https://autoroll.skia.org/r/binaryen-emscripten-releases.

Hmm, I am not sure if this is the case. My bots are running against the latest main branch of Binaryen, always rebuilding it from source for every test run. i.e. my bots do not use the binaryen roller.

Or do you mean that the root cause is an intentional change in Binaryen, which Emscripten is deliberately not yet compatible with?

@juj, maybe it would be worth syncing your CI builders to latest known-good revisions for llvm and binaryen?

That would hide issues that stem from LLVM and Binaryen, no? The purpose with my bots is not to hide these issues, but to continuously see them. We do want to always be compatible with the latest main branches from both projects, right?

I don't mind if my bots read red due to an intermittent incompatibility between these repos. It's good to be able to identify such incompatibilities quickly. Still worth reporting those?

[sbc100]

The point of the emscripten-release rollers is only roll in know-good revisions of LLVM and binaryen.

If you are doing the same job (i.e. trying to vet changes as they land on main) then you will inevitably end up finding some of the same issues that the auto-rollers are already already reporting. i.e. I'm not sure its very useful if you report errors that the auto-roller are also already reporting.

Where you waterfall is very useful is in the breadth of coverage. You run configurations that our other waterfalls don't cover. It might be more efficient if you applied your broad testing only to revision that had already passed the narrower set of auto-roller tests?

On the other hand its not such a bad situation if your CI reports the same failures that emscripten-releases CI already is reported (as in this case).

(If you fallow the link above you can see that our roller started reporting this issue a 19 hours or so ago: LinkError: WebAssembly.Instance(): table import 3 has a larger maximum size 6 than the module's declared maximum 4)

[juj]

I think I should bookmark the autorollers, and check those first before reporting an issue, so that I don't report something that is already known. Should we close this issue then?

[sbc100]

The 4 auto-rollers in question can be found here: https://autoroll.skia.org/?filter=emscripten

No, we can leave this open. I don't think there is another open issue for this.

[juj]

Great, thanks, bookmarked.

[aheejin]

Sorry, yes I'm on it, I'll push the fix today.