Skip to content

Commit 005d2ea

Browse files
authored
Improve motive chart (#82)
* feat: add startupProbe * feat: add minReadySeconds,terminationGracePeriodSeconds & revisionHistoryLimit
1 parent 41dd250 commit 005d2ea

File tree

3 files changed

+13
-1
lines changed

3 files changed

+13
-1
lines changed

charts/multi-service-deployment/Chart.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ type: application
77
# This is the chart version. This version number should be incremented each time you make changes
88
# to the chart and its templates, including the app version.
99
# Versions are expected to follow Semantic Versioning (https://semver.org/)
10-
version: 0.1.8
10+
version: 0.1.9
1111

1212
# This is the version number of the application being deployed. This version number should be
1313
# incremented each time you make changes to the application. Versions are not expected to

charts/multi-service-deployment/templates/deployment.yaml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,8 @@ spec:
1010
replicas: {{ .Values.replicaCount }}
1111
{{- end }}
1212
{{- end }}
13+
minReadySeconds: {{ .Values.minReadySeconds | default 30 }}
14+
revisionHistoryLimit: {{ .Values.revisionHistoryLimit | default 3 }}
1315
selector:
1416
matchLabels:
1517
{{- include "multi-service-deployment.selectorLabels" . | nindent 6 }}
@@ -25,6 +27,7 @@ spec:
2527
{{- toYaml .Values.podLabels | nindent 8 }}
2628
{{- end }}
2729
spec:
30+
terminationGracePeriodSeconds: {{ .Values.terminationGracePeriodSeconds | default 60 }}
2831
{{- with .Values.imagePullSecrets }}
2932
imagePullSecrets:
3033
{{- toYaml . | nindent 8 }}
@@ -53,6 +56,8 @@ spec:
5356
{{- toYaml .Values.livenessProbe | nindent 12 }}
5457
readinessProbe:
5558
{{- toYaml .Values.readinessProbe | nindent 12 }}
59+
startupProbe:
60+
{{- toYaml .Values.startupProbe | nindent 12 }}
5661
resources:
5762
{{- toYaml .Values.resources | nindent 12 }}
5863
{{- with .Values.nodeSelector }}

charts/multi-service-deployment/values.yaml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -150,3 +150,10 @@ prometheusRule:
150150
# severity: page
151151
# annotations:
152152
# summary: High request latency
153+
154+
revisionHistoryLimit: 3
155+
minReadySeconds: 30
156+
terminationGracePeriodSeconds: 60
157+
livenessProbe: {}
158+
readinessProbe: {}
159+
startupProbe: {}

0 commit comments

Comments
 (0)