Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] v4alpha1 CRDs #5790

Draft
wants to merge 10 commits into
base: dev/v4
Choose a base branch
from
Draft

[WIP] v4alpha1 CRDs #5790

wants to merge 10 commits into from

Commits on Oct 16, 2024

  1. [WIP] make gotest will not yet pass. Add emissary-ingress.dev/v4alpha…

    …1. Allow make generate-fast to work with it.
    
    Signed-off-by: Flynn <[email protected]>
    kflynn committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    af32d72 View commit details
    Browse the repository at this point in the history
  2. Copy encoding/json and sigs.k8s.io/yaml into our tree

    Turns out that the Go ecosystem doesn't currently offer control over the tag used when serializing or deserializing JSON or YAML. This is pretty appalling. We need control over the tag, and the most sane way I've found to support that is _copying all of encoding/json and sigs.k8s.io/yaml into our tree_ and modifying them. Ugh. Bad ecosystem!
    
    Signed-off-by: Flynn <[email protected]>
    kflynn committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    86fca8b View commit details
    Browse the repository at this point in the history
  3. Brutal hack: pkg/json now looks for the v3 tag, then falls back to th…

    …e json tag (and, also, it doesn't rely on internal imports)
    
    Signed-off-by: Flynn <[email protected]>
    kflynn committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    d848e60 View commit details
    Browse the repository at this point in the history
  4. Brutal hack: pkg/yaml now uses v3 before falling back to yaml or json…

    … (as needed).
    
    Signed-off-by: Flynn <[email protected]>
    kflynn committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    40d1957 View commit details
    Browse the repository at this point in the history
  5. Have the start of cmd/migrator to migrate between v3 & v4 CRDs. Use i…

    …t to migrate all the v3alpha1 testdata for emissary-ingress.dev/v4alpha1 over to proper v4 CRDs.
    
    Signed-off-by: Flynn <[email protected]>
    kflynn committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    3e925af View commit details
    Browse the repository at this point in the history
  6. Update to Go 1.23

    Signed-off-by: Flynn <[email protected]>
    kflynn committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    b058aff View commit details
    Browse the repository at this point in the history
  7. pkg/json and pkg/yaml don't lint cleanly -- because the upstream vers…

    …ions don't!
    
    Really, standard library authors? Really??
    
    Signed-off-by: Flynn <[email protected]>
    kflynn committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    3a040eb View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2024

  1. Configuration menu
    Copy the full SHA
    b893785 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    236f7fc View commit details
    Browse the repository at this point in the history
  3. Use V3 JSON when handing the snapshot over to the Python side of the …

    …world.
    
    This is the point where we _start_ to have some functionality working. The FakeCollision test passes after this change(!!).
    
    Signed-off-by: Flynn <[email protected]>
    kflynn committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    9e8c825 View commit details
    Browse the repository at this point in the history