v4 fixes for 5702 and 5714 #5726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sekar Saravanan <[email protected]> (cherry picked from commit e8ca650)
… build process. Signed-off-by: Flynn <[email protected]> (cherry picked from commit d04280e)
Signed-off-by: Flynn <[email protected]> (cherry picked from commit 642c784)
dosubot
bot
added
the
size:XXL
dosubot
bot
added
dependencies
kflynn
added
size:L
dosubot
bot
added
size:XXL
Signed-off-by: Flynn <[email protected]>
Signed-off-by: Flynn <[email protected]>
… resource fixed Signed-off-by: Sekar Saravanan <[email protected]>
Huge props to @sekar-saravanan for finding this bug in the first place. Signed-off-by: Flynn <[email protected]>
Signed-off-by: Flynn <[email protected]>
Signed-off-by: Flynn <[email protected]>
dosubot
bot
added
size:XL
kflynn
removed
dependencies
|
(I initially submitted this as a PR against |
Signed-off-by: Flynn <[email protected]>
Signed-off-by: Flynn <[email protected]>
Signed-off-by: Flynn <[email protected]>
…mapping in one step) Signed-off-by: Flynn <[email protected]>
|
@sekar-saravanan and @the-wondersmith, it'd be good for y'all to look at this too. |
Alice-Lilith
approved these changes
Jul 25, 2024
| type IRCluster struct { | ||
| IRResource | ||
| BarHostname string `json:"_hostname"` // Why this _and_ hostname? | ||
| BarNamespace string `json:"_namespace"` // Why this _and_ namespace? |
There was a problem hiding this comment.
I don't like this but I get why it's here for now
There was a problem hiding this comment.
You and me both. I'll figure out what up with this soon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is @sekar-saravanan's fixes for #5702 and #5714 combined with my test cases.
Reviewers, this is definitely best reviewed commit by commit.
Note also that irtype.go is known to be incomplete -- but, as demonstrated, it's already good enough to do useful testing work!
Finally, note also that I have not tried to backport this work to the v3 branch. It's definitely doable, but since this involves a couple of chainsaw commits, there'll be some weirdness around the Go import paths, I'm sure.