Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Double-click on handle closes the drawer even if dismissible is set to false #362

Open
franciscohanna92 opened this issue May 28, 2024 · 1 comment · May be fixed by #363
Open

Double-click on handle closes the drawer even if dismissible is set to false #362

franciscohanna92 opened this issue May 28, 2024 · 1 comment · May be fixed by #363

Comments

@franciscohanna92
Copy link

franciscohanna92 commented May 28, 2024 •
edited
Loading

A non-dimissible drawer will still close when double-clicking the drag handle.

Reproduction: Codesandbox
@franciscohanna92 franciscohanna92 linked a pull request May 28, 2024 that will close this issue
Open
@EladBezalel
Copy link

EladBezalel commented Jul 11, 2024 •
edited
Loading

I ended up doing

React.cloneElement(<Drawer.Handle />, {
  onDoubleClick: () => {},
})}

Hopefully your fix will get merged soon 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prevent closing non-dimissible drawer on handle double-click franciscohanna92/vaul
2 participants
@EladBezalel @franciscohanna92