Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

onOpenChange still getting called twice when user clicks outside of Drawer #345

Open
phxgg opened this issue May 7, 2024 · 1 comment
Open

onOpenChange still getting called twice when user clicks outside of Drawer #345

phxgg opened this issue May 7, 2024 · 1 comment

Comments

@phxgg
Copy link

phxgg commented May 7, 2024 •
edited
Loading

Related issue that was closed: #290

My guess is that this issue was reintroduced by accident.

Read this comment for more info #291 (comment)
@phxgg phxgg changed the title #290 is still not fixed onOpenChange still getting called twice when user clicks outside of Drawer May 7, 2024
@misaelvillaverde
Copy link

I think the issue is that the vaul is triggering the close action twice.

After setting a ref to prevent changing my state by the onOpenChange function being called with the same value twice, the vaul was still being closed with my controller state staying true :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@misaelvillaverde @phxgg