Incorrect monorepo package resolution? @glimmer/syntax -> @glimmer/util, but in ember-source, except not found #817
Comments
|
The problem here is probably that we are looking at this file at all:
In a normal ember app, you don't have a real Did you add |
|
Yup, I added it for: import { getTemplateLocals } from '@glimmer/syntax';used for in-browser compliing strict mode stuff on https://limber.glimdown.com how does one adjust builtin compat rules? |
|
It's hard to fix your case without breaking the built-in case. One workaround you can try, since you have a monorepo anyway, is to import from Another option is to find what you need from inside |
|
awesome, thanks! I think I'll try the new package route, because I've been wanting to make the gjs compiler in here its own library anyway and publish that. I'll report back soon™! |
|
This is related, but still interesting, -import { getTemplateLocals } from '@glimmer/syntax';
-import { precompileTemplate } from '@ember/template-compilation';
+import { getTemplateLocals, precompileTemplate } from '@ember/template-compilation';(and removing results in the build succeeding, but, with a runtime error:which comes from (probably more |
|
🤔 I'm still having issues with module resolution it seems, even ember stuff: for example, in tracked-built-ins, I'm getting an error that this utils module doesn't exist: but, it's right here: when debugging I would expect that the |
|
Just connecting the issues I'm finding together: tracked-tools/tracked-built-ins#96 (unexpected new issue 🤷 ) |
|
alright, with some git references in my package.json, and removing which... I assume means that the template compiler just isn't compatible with ember 3.27 + embroider? |
You really don't want them in there if you want true modules and tree shaking. We only put things in there that absolutely must be for compatibility. Under embroider ES module imports don't go through the runtime loader. |
|
bug for the template compiler issue: emberjs/ember.js#19568 |
|
idk if I've created too many x/y problems by doing this, but, I think we can close this issue, as the recommendation is to either:
|
ref: glimmerjs/glimmer.js#345
Reason why I'm thinking this might be a dependency resolution issue,
In this PR where renovate upgrades my app from 3.26.x to 3.27.x
I get the error
Log
And here is where I think it might be a resolution problem,
ember-sourceis in my monorepo-root node_modules (with @glimmer/util.js):the same path does not exist in my app's local node_modules
in my app's package.json:
The text was updated successfully, but these errors were encountered: