Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

breaking showRootNode in 2.1.0 #18

Closed
abarke opened this issue Jun 29, 2023 · 1 comment
Closed

breaking showRootNode in 2.1.0 #18

abarke opened this issue Jun 29, 2023 · 1 comment
Assignees
@jawwad-hassan89
Labels
documentation Improvements or additions to documentation

Comments

@abarke
Copy link

abarke commented Jun 29, 2023 •
edited

Might be worth noting in the CHANGELOG.md that the default for showRootNode is now true in version 2.1.0.

See 2f80fa5#diff-72fd825ad17ce7800a2078e06f0dff1e12836ee59760465e78d9a5d222cebd15R64

This caused a regression in our app where we did not explicitly set showRootNode: false
@jawwad-hassan89 jawwad-hassan89 added the documentation Improvements or additions to documentation label Jun 30, 2023
@jawwad-hassan89 jawwad-hassan89 self-assigned this Jun 30, 2023
@jawwad-hassan89
Copy link
Collaborator

This is definitely an oversight in our part, and apologize for the inconvenience. We will update the changelog to reflect the relevant changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jawwad-hassan89 jawwad-hassan89

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@abarke @jawwad-hassan89