From e748f537762354dc97191f939c2dca7693549d1a Mon Sep 17 00:00:00 2001 From: Jonathan Munz Date: Mon, 12 Aug 2024 18:31:52 -0400 Subject: [PATCH] EMBR-4337 fix debug stuff --- .../__tests__/__mocks__/ios/BridgingHeader.h | 1 - packages/core/scripts/setup/ios.ts | 35 ------------------- packages/core/scripts/setup/uninstall.ts | 3 -- packages/core/scripts/util/ios.ts | 2 +- 4 files changed, 1 insertion(+), 40 deletions(-) diff --git a/packages/core/scripts/__tests__/__mocks__/ios/BridgingHeader.h b/packages/core/scripts/__tests__/__mocks__/ios/BridgingHeader.h index 410756a6..e11d920b 100644 --- a/packages/core/scripts/__tests__/__mocks__/ios/BridgingHeader.h +++ b/packages/core/scripts/__tests__/__mocks__/ios/BridgingHeader.h @@ -1,4 +1,3 @@ // // Use this file to import your target's public headers that you would like to expose to Swift. // - \ No newline at end of file diff --git a/packages/core/scripts/setup/ios.ts b/packages/core/scripts/setup/ios.ts index f21438f6..fa698fdf 100644 --- a/packages/core/scripts/setup/ios.ts +++ b/packages/core/scripts/setup/ios.ts @@ -195,38 +195,3 @@ import EmbraceIO } `; }; - -export const addBridgingHeader = async (projectName: string) => { - const project = await xcodePatchable({name: projectName}); - - // TODO check project to see if SWIFT_OBJC_BRIDGING_HEADER is already set - // if it is just return - // otherwise... add the bridging header file - const filename = `${projectName}-Bridging-Header.h`; - const p = path.join("ios", projectName); - if (fs.existsSync(p)) { - logger.warn("bridging header already exists"); - return true; - } - - fs.writeFileSync(p, getBridgingHeaderContents()); - - const nameWithCaseSensitive = findNameWithCaseSensitiveFromPath( - project.path, - projectName, - ); - project.addFile( - nameWithCaseSensitive, - `${nameWithCaseSensitive}/${filename}`, - ); - project.patch(); - - // TODO SWIFT_OBJC_BRIDGING_HEADER = "${filename}"; -}; - -const getBridgingHeaderContents = () => { - return `// -// Use this file to import your target's public headers that you would like to expose to Swift. -// -`; -}; diff --git a/packages/core/scripts/setup/uninstall.ts b/packages/core/scripts/setup/uninstall.ts index ae5c103c..12a08a48 100644 --- a/packages/core/scripts/setup/uninstall.ts +++ b/packages/core/scripts/setup/uninstall.ts @@ -145,8 +145,6 @@ export const removeEmbraceImportAndStartFromFile = ( const textToAdd = getText(item); const toDelete = Array.isArray(textToAdd) ? textToAdd : [textToAdd]; - console.log(item.textToAdd); - toDelete.forEach(line => { logger.log(`Deleting ${line} from ${fileName}`); @@ -236,7 +234,6 @@ export const removeEmbraceFromXcode = () => { resolve(project.writeSync()); }) .catch(r => { - console.log(r); logger.error( "Could not find bundle phase, Please refer to the docs at https://embrace.io/docs/react-native/integration/upload-symbol-files/", ); diff --git a/packages/core/scripts/util/ios.ts b/packages/core/scripts/util/ios.ts index 247fd97b..2b9c5581 100644 --- a/packages/core/scripts/util/ios.ts +++ b/packages/core/scripts/util/ios.ts @@ -373,7 +373,7 @@ const getBridgingHeaderContents = () => { return `// // Use this file to import your target's public headers that you would like to expose to Swift. // - `; +`; }; export const findNameWithCaseSensitiveFromPath = (