diff --git a/embrace-android-core/src/main/kotlin/io/embrace/android/embracesdk/internal/session/lifecycle/ActivityLifecycleListener.kt b/embrace-android-core/src/main/kotlin/io/embrace/android/embracesdk/internal/session/lifecycle/ActivityLifecycleListener.kt index 359016939f..0f4ce5da97 100644 --- a/embrace-android-core/src/main/kotlin/io/embrace/android/embracesdk/internal/session/lifecycle/ActivityLifecycleListener.kt +++ b/embrace-android-core/src/main/kotlin/io/embrace/android/embracesdk/internal/session/lifecycle/ActivityLifecycleListener.kt @@ -13,14 +13,14 @@ public interface ActivityLifecycleListener { * * @param activity details of the activity */ - public fun onView(activity: Activity) {} + public fun onActivityStarted(activity: Activity) {} /** * Triggered when an activity is closed. * * @param activity details of the activity */ - public fun onViewClose(activity: Activity) {} + public fun onActivityStopped(activity: Activity) {} /** * Triggered when an activity is created. diff --git a/embrace-android-sdk/src/main/java/io/embrace/android/embracesdk/internal/capture/crumbs/EmbraceBreadcrumbService.kt b/embrace-android-sdk/src/main/java/io/embrace/android/embracesdk/internal/capture/crumbs/EmbraceBreadcrumbService.kt index 7b5f2d71c2..13012fb405 100644 --- a/embrace-android-sdk/src/main/java/io/embrace/android/embracesdk/internal/capture/crumbs/EmbraceBreadcrumbService.kt +++ b/embrace-android-sdk/src/main/java/io/embrace/android/embracesdk/internal/capture/crumbs/EmbraceBreadcrumbService.kt @@ -96,7 +96,7 @@ internal class EmbraceBreadcrumbService( } } - override fun onView(activity: Activity) { + override fun onActivityStarted(activity: Activity) { if (configService.breadcrumbBehavior.isAutomaticActivityCaptureEnabled()) { logView(activity.javaClass.name, clock.now()) } @@ -105,7 +105,7 @@ internal class EmbraceBreadcrumbService( /** * Close all open fragments when the activity closes */ - override fun onViewClose(activity: Activity) { + override fun onActivityStopped(activity: Activity) { if (configService.breadcrumbBehavior.isAutomaticActivityCaptureEnabled()) { dataSourceModuleProvider()?.viewDataSource?.dataSource?.onViewClose() } diff --git a/embrace-android-sdk/src/main/java/io/embrace/android/embracesdk/internal/session/lifecycle/ActivityLifecycleTracker.kt b/embrace-android-sdk/src/main/java/io/embrace/android/embracesdk/internal/session/lifecycle/ActivityLifecycleTracker.kt index 789605d31e..64027730fb 100644 --- a/embrace-android-sdk/src/main/java/io/embrace/android/embracesdk/internal/session/lifecycle/ActivityLifecycleTracker.kt +++ b/embrace-android-sdk/src/main/java/io/embrace/android/embracesdk/internal/session/lifecycle/ActivityLifecycleTracker.kt @@ -77,7 +77,7 @@ internal class ActivityLifecycleTracker( updateStateWithActivity(activity) stream(listeners) { listener: ActivityLifecycleListener -> try { - listener.onView(activity) + listener.onActivityStarted(activity) } catch (ex: Exception) { logger.logWarning(ERROR_FAILED_TO_NOTIFY) logger.trackInternalError(InternalErrorType.ACTIVITY_LISTENER_FAIL, ex) @@ -104,7 +104,7 @@ internal class ActivityLifecycleTracker( override fun onActivityStopped(activity: Activity) { stream(listeners) { listener: ActivityLifecycleListener -> try { - listener.onViewClose(activity) + listener.onActivityStopped(activity) } catch (ex: Exception) { logger.logWarning(ERROR_FAILED_TO_NOTIFY) logger.trackInternalError(InternalErrorType.ACTIVITY_LISTENER_FAIL, ex) diff --git a/embrace-android-sdk/src/test/java/io/embrace/android/embracesdk/session/ActivityLifecycleTrackerTest.kt b/embrace-android-sdk/src/test/java/io/embrace/android/embracesdk/session/ActivityLifecycleTrackerTest.kt index 8df41eb19b..ca92cce8ff 100644 --- a/embrace-android-sdk/src/test/java/io/embrace/android/embracesdk/session/ActivityLifecycleTrackerTest.kt +++ b/embrace-android-sdk/src/test/java/io/embrace/android/embracesdk/session/ActivityLifecycleTrackerTest.kt @@ -121,7 +121,7 @@ internal class ActivityLifecycleTrackerTest { activityLifecycleTracker.onActivityStarted(mockActivity) - verify { mockActivityLifecycleListener.onView(mockActivity) } + verify { mockActivityLifecycleListener.onActivityStarted(mockActivity) } assertEquals(mockActivity, activityLifecycleTracker.foregroundActivity) } @@ -153,7 +153,7 @@ internal class ActivityLifecycleTrackerTest { activityLifecycleTracker.onActivityStopped(mockActivity) - verify { mockActivityLifecycleListener.onViewClose(mockActivity) } + verify { mockActivityLifecycleListener.onActivityStopped(mockActivity) } } @Test