From 11f19594a67d7dddd78faa4c607951faaa101f8f Mon Sep 17 00:00:00 2001
From: NullVoxPopuli <199018+NullVoxPopuli@users.noreply.github.com>
Date: Sun, 3 May 2026 00:41:54 -0400
Subject: [PATCH 1/4] Make the rendering benchmark focus more on rendering
---
smoke-tests/benchmark-app/app/app.js | 9 ---------
.../benchmark-app/app/config/environment.js | 10 ----------
smoke-tests/benchmark-app/app/router.js | 9 ---------
.../app/{services => templates}/cell.js | 0
.../app/{services => templates}/state.js | 7 +++----
.../benchmark-app/app/templates/the-table.gjs | 8 ++++----
.../app/{services => templates}/utils.js | 5 -----
smoke-tests/benchmark-app/index.html | 14 +++++++-------
smoke-tests/benchmark-app/package.json | 1 -
9 files changed, 14 insertions(+), 49 deletions(-)
delete mode 100644 smoke-tests/benchmark-app/app/app.js
delete mode 100644 smoke-tests/benchmark-app/app/config/environment.js
delete mode 100644 smoke-tests/benchmark-app/app/router.js
rename smoke-tests/benchmark-app/app/{services => templates}/cell.js (100%)
rename smoke-tests/benchmark-app/app/{services => templates}/state.js (87%)
rename smoke-tests/benchmark-app/app/{services => templates}/utils.js (94%)
diff --git a/smoke-tests/benchmark-app/app/app.js b/smoke-tests/benchmark-app/app/app.js
deleted file mode 100644
index 98252c239e2..00000000000
--- a/smoke-tests/benchmark-app/app/app.js
+++ /dev/null
@@ -1,9 +0,0 @@
-import Application from 'ember-strict-application-resolver';
-
-export default class App extends Application {
- modules = {
- ...import.meta.glob('./router.*', { eager: true }),
- ...import.meta.glob('./templates/application.*', { eager: true }),
- ...import.meta.glob('./services/state.*', { eager: true }),
- };
-}
diff --git a/smoke-tests/benchmark-app/app/config/environment.js b/smoke-tests/benchmark-app/app/config/environment.js
deleted file mode 100644
index 8530468c0fd..00000000000
--- a/smoke-tests/benchmark-app/app/config/environment.js
+++ /dev/null
@@ -1,10 +0,0 @@
-const ENV = {
- modulePrefix: 'benchmark-app',
- environment: import.meta.env.DEV ? 'development' : 'production',
- rootURL: '/',
- locationType: 'history',
- EmberENV: {},
- APP: {},
-};
-
-export default ENV;
diff --git a/smoke-tests/benchmark-app/app/router.js b/smoke-tests/benchmark-app/app/router.js
deleted file mode 100644
index ce92066c976..00000000000
--- a/smoke-tests/benchmark-app/app/router.js
+++ /dev/null
@@ -1,9 +0,0 @@
-import EmberRouter from '@embroider/router';
-import config from 'benchmark-app/config/environment';
-
-export default class Router extends EmberRouter {
- location = config.locationType;
- rootURL = config.rootURL;
-}
-
-Router.map(function () {});
diff --git a/smoke-tests/benchmark-app/app/services/cell.js b/smoke-tests/benchmark-app/app/templates/cell.js
similarity index 100%
rename from smoke-tests/benchmark-app/app/services/cell.js
rename to smoke-tests/benchmark-app/app/templates/cell.js
diff --git a/smoke-tests/benchmark-app/app/services/state.js b/smoke-tests/benchmark-app/app/templates/state.js
similarity index 87%
rename from smoke-tests/benchmark-app/app/services/state.js
rename to smoke-tests/benchmark-app/app/templates/state.js
index 3b1249018ae..4a4f977d9c9 100644
--- a/smoke-tests/benchmark-app/app/services/state.js
+++ b/smoke-tests/benchmark-app/app/templates/state.js
@@ -1,10 +1,9 @@
-import Service from '@ember/service';
import { tracked } from '@glimmer/tracking';
import { trackedArray } from '@ember/reactive/collections';
-import { run, runLots, add, update, swapRows, deleteRow } from './utils.js';
+import { run, runLots, add, update, swapRows } from './utils.js';
-export default class State extends Service {
+export class State {
data = new trackedArray();
id = 1;
@tracked selected;
@@ -60,4 +59,4 @@ export default class State extends Service {
isSelected = ({ id }) => {
return this.selected === id;
};
-}
\ No newline at end of file
+}
diff --git a/smoke-tests/benchmark-app/app/templates/the-table.gjs b/smoke-tests/benchmark-app/app/templates/the-table.gjs
index 79c38146d68..4b2c8da84ea 100644
--- a/smoke-tests/benchmark-app/app/templates/the-table.gjs
+++ b/smoke-tests/benchmark-app/app/templates/the-table.gjs
@@ -1,13 +1,13 @@
import Component from '@glimmer/component';
import { fn } from '@ember/helper';
-import { service } from '@ember/service';
+import { State } from './state.js';
export class TheTable extends Component {
- @service state;
+ state = new State();
/**
* We currently don't have a way to emit HTML with no invisible characters
- * and have the template look nice.
+ * and have the template look nice.
*/
@@ -28,4 +28,4 @@ export class TheTable extends Component {
-}
\ No newline at end of file
+}
diff --git a/smoke-tests/benchmark-app/app/services/utils.js b/smoke-tests/benchmark-app/app/templates/utils.js
similarity index 94%
rename from smoke-tests/benchmark-app/app/services/utils.js
rename to smoke-tests/benchmark-app/app/templates/utils.js
index f6f3f1b5179..b5f2d06820e 100644
--- a/smoke-tests/benchmark-app/app/services/utils.js
+++ b/smoke-tests/benchmark-app/app/templates/utils.js
@@ -120,8 +120,3 @@ export const swapRows = (data) => {
}
};
-export const deleteRow = (data, id) => {
- return data.filter((d) => {
- return d.id !== id;
- });
-};
\ No newline at end of file
diff --git a/smoke-tests/benchmark-app/index.html b/smoke-tests/benchmark-app/index.html
index d9a7949c5ca..4f08e3408e8 100644
--- a/smoke-tests/benchmark-app/index.html
+++ b/smoke-tests/benchmark-app/index.html
@@ -6,18 +6,18 @@
-
+
-
+