Skip to content

Omit code for optional features that are turned off #18710

@mehulkar

Description

@mehulkar
Contributor

Talked to @pzuraq and he mentioned that it's theoretically possible to strip out ember-source code that won't be used due to optional-features. This tooling would be great incentive for apps to invest in moving in the direction the core team/communities deems as the way forward.

Not sure where this would happen, but opening here since it seems like a build time concern

(Reopening ember-cli/ember-cli#9021)

Activity

rwjblue

rwjblue commented on Apr 2, 2020

@rwjblue
Member

Ya, we definitely have the tooling in place to do this safely.

lifeart

lifeart commented on Sep 10, 2020

@lifeart
Contributor

@rwjblue, @mehulkar is it something related to @glimmer/env? https://github.com/babel/ember-cli-babel/blob/master/index.js#L462 we have to search for global flags and replace it to FALSE for production builds?

lifeart

lifeart commented on Sep 10, 2020

@lifeart
Contributor

#18060 may be related

chancancode

chancancode commented on Sep 25, 2020

@chancancode
Member

I don't think so, #18060 is talking about canary features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @rwjblue@locks@chancancode@mehulkar@lifeart

        Issue actions

          Omit code for optional features that are turned off · Issue #18710 · emberjs/ember.js