-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add smoke-tests for types, build, etc #9633
Open
NullVoxPopuli
wants to merge
2
commits into
main
Choose a base branch
from
smoke-test-with-non-pnpm
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NullVoxPopuli
changed the title
Smoke test with non pnpm
Add smoke-tests for types, build, etc
Jan 9, 2025
NullVoxPopuli
commented
Jan 10, 2025
NullVoxPopuli
force-pushed
the
smoke-test-with-non-pnpm
branch
from
January 11, 2025 23:03
9cc348f
to
7b0eda0
Compare
NullVoxPopuli
force-pushed
the
smoke-test-with-non-pnpm
branch
2 times, most recently
from
January 14, 2025 22:22
fb5e4d5
to
d1de3f5
Compare
NullVoxPopuli
commented
Jan 14, 2025
.npmrc
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without these changes not all node_modules directories have the right bins in node_modules -- for example, @warp-drive/ember did not have glint
, and would fail to build its types
NullVoxPopuli
force-pushed
the
smoke-test-with-non-pnpm
branch
from
January 15, 2025 21:35
bf68cd4
to
e134254
Compare
…ompilerOptions#types Fix: #9630 Fix: ember-cli/ember-cli#10611 Related: - ember-cli/ember-cli#10613 Unblocks: - ember-cli/ember-cli#10612
NullVoxPopuli
force-pushed
the
smoke-test-with-non-pnpm
branch
from
January 22, 2025 15:19
27208ad
to
bed0680
Compare
NullVoxPopuli
added a commit
to NullVoxPopuli/ts-types-package-json-exports-proof-for-ember-data
that referenced
this pull request
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minimal reproduction of the problem I'm addressing: https://github.com/NullVoxPopuli/ts-types-package-json-exports-proof-for-ember-data
Description
Supersedes: #9631
Resolves: #9630
ember-data / warp-drive has enough going on it to warrant testing if new projects in various scenarios will work:
Unblocks:
Notes for the release
fix: tsconfig.json#compilerOptions#types can now use the package.json#exports paths, example:
Notes for review
NPM is not as understanding when it comes to tarballs:
the install-time peer checking here isn't as important as the post-install peer checking -- we don't want npm using the versions from package.json exactly, but the versions installed the specifiers in the package.json -- kinda surprised they have this bug, tbh