From 06a19fcc64fc71a4df9d129508b0442e87176343 Mon Sep 17 00:00:00 2001 From: NullVoxPopuli <199018+NullVoxPopuli@users.noreply.github.com> Date: Tue, 14 Jan 2025 18:48:17 -0500 Subject: [PATCH] Update for npm, remove yarn --- .github/workflows/compat-tests.yml | 5 ++++- scripts/test-package-manager.mjs | 8 +++++++- 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/.github/workflows/compat-tests.yml b/.github/workflows/compat-tests.yml index 6e11839b72..65537c4876 100644 --- a/.github/workflows/compat-tests.yml +++ b/.github/workflows/compat-tests.yml @@ -90,7 +90,10 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - packageManager: [npm, yarn, pnpm] + packageManager: + - npm + # - yarn # yarn@1 has not been reliable, if yarn@4 were easy to setup, we could test against that + - pnpm kind: - false # Test vanilla pnpm -r - alpha # requires unstable-preview-types folder for each package diff --git a/scripts/test-package-manager.mjs b/scripts/test-package-manager.mjs index fcf74d8069..13e5dcce8a 100644 --- a/scripts/test-package-manager.mjs +++ b/scripts/test-package-manager.mjs @@ -261,7 +261,13 @@ async function runNoThrow(cwd, cmd) { async function install(packageManager, cwd) { // All package managers have an install command - await $({ preferLocal: true, shell: true, cwd, stdio: 'inherit' })`${packageManager} install`; + switch (packageManager) { + case 'npm': + // npm complains about tgz files in the version specifier part of package.json + await $({ preferLocal: true, shell: true, cwd, stdio: 'inherit' })`${packageManager} install --force`; + default: + await $({ preferLocal: true, shell: true, cwd, stdio: 'inherit' })`${packageManager} install`; + } } async function typecheck(packageManager, cwd) {