-
-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Styles don't play nice with disabled application-template-wrapper #422
Comments
@josemarluedke if we wrap it, does it mess up styles if it is double wrapped? |
It does mess up a few things if double wrapped. |
Perhaps we should just put a note that you should wrap it? |
I just ran in to this. I had to: |
@NullVoxPopuli any interest in taking a look at a fix? Can you not manually wrap in |
omg yes. Yesterday me was an idiot. thanks! |
When using addon-docs on an app with
application-template-wrapper
set tofalse
(which is default in octane), the app styles don't work well. See below:ember-cli-addon-docs/addon/styles/addon.scss
Lines 51 to 58 in 7574272
This is simple to fix, but it would be better to not break for these cases.
The fix is just wrapping the content of application.hbs with a
div
with classesember-view
:The text was updated successfully, but these errors were encountered: