Skip to content

Commit 22e4a48

Browse files
Merge pull request #413 from phorest/remove-global-ember-import
Remove global Ember import
2 parents 3de9200 + 14137dc commit 22e4a48

File tree

3 files changed

+354
-37
lines changed

3 files changed

+354
-37
lines changed

addon/services/apollo.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
import Ember from 'ember';
21
import { get, set, setProperties, defineProperty } from '@ember/object';
32
import { sendEvent } from '@ember/object/events';
43
import RSVP from 'rsvp';
@@ -17,6 +16,7 @@ import { run } from '@ember/runloop';
1716
import { QueryManager } from '../index';
1817
import { waitForPromise } from '@ember/test-waiters';
1918
import { tracked } from '@glimmer/tracking';
19+
import { isTesting } from '@embroider/macros';
2020

2121
const apolloObservableWeakMap = new WeakMap();
2222
const apolloUnsubscribeWeakMap = new WeakMap();
@@ -137,7 +137,7 @@ export default class ApolloService extends Service {
137137
let config = getOwner(this).resolveRegistration('config:environment');
138138
if (config && config.apollo) {
139139
return config.apollo;
140-
} else if (Ember.testing) {
140+
} else if (isTesting()) {
141141
return {
142142
apiURL: 'http://testserver.example/v1/graph',
143143
};

package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@
3636
"dependencies": {
3737
"@apollo/client": "^3.2.1",
3838
"@ember/test-waiters": "~3.0.0",
39+
"@embroider/macros": "^1.5.0",
3940
"@glimmer/tracking": "^1.0.2",
4041
"broccoli-graphql-filter": "^1.0.0",
4142
"ember-auto-import": "^1.6.0",
@@ -49,7 +50,7 @@
4950
"broccoli-asset-rev": "^3.0.0",
5051
"ember-cli": "~3.21.2",
5152
"ember-cli-dependency-checker": "^3.2.0",
52-
"ember-cli-htmlbars": "^5.3.1",
53+
"ember-cli-htmlbars": "^5.7.2",
5354
"ember-cli-inject-live-reload": "^2.0.2",
5455
"ember-cli-terser": "^4.0.0",
5556
"ember-compatibility-helpers": "^1.2.1",

0 commit comments

Comments
 (0)