-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please add more descriptive error message for hostWhitelist property in environment.js #88
Comments
|
@danmcclain Ah, thanks! I only read the README 👍 |
The website is the canonical place for usage information, we shifted away from the README, as it would get unwieldy |
I do believe we can add a link to that error message so we can point users in the correct direction, thanks! |
Will this message also be displayed if there is a whitelist but the host is not on it? Or will there be a different message? If the same message is used for both, providing a more specific message that identifies the host that failed the match would be helpful. Two small changes to the manual might help with this: It is very, very easy to put the fastboot:{} in the wrong part of the environment.js. Sounds like the OP was having some confusion about that. In the manual, putting it above the EmberENV: {} and App: {} rather than below them might make it clearer that it has to appear at the let ENV: { ... here ... } level. I had to read it a few times to be sure of that myself. Also, while ember serve will detect environment.js changes and rebuild the project, I think fastboot may not be picking up its changes under that condition. I had better luck stopping ember serve and restarting it, but I only discovered that by accident after making repeated changes and wondering why I was still getting the error. |
Any chance of actually updating this error message as @danmcclain suggested? It's 2020 and the error message is still pretty cryptic. :) |
Hi I've no idea what that means. I struggled to understand where this hostWhitelist should be defined without success.
My currently dirty environment.js has this:
And the erro I get when starting FastBoot with:
Is this:
The text was updated successfully, but these errors were encountered: