Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor destroyAppInstanceInMs system #240

Open
rwjblue opened this issue Oct 30, 2019 · 0 comments
Open

Refactor destroyAppInstanceInMs system #240

rwjblue opened this issue Oct 30, 2019 · 0 comments
Milestone

Comments

@rwjblue
Copy link
Member

rwjblue commented Oct 30, 2019

Currently, the visit promise is not entangled with the timeout at all, and the timeout is used to set the result.error object. Instead, we should refactor so that when the timeout expires the current visit is "canceled" (essentially calling .destroy() on the underlying ember application that is being booted/visited) and reject the visit promise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants