-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
suppressBrowserRender should either be renamed or updated #42
Comments
cc @rondale-sc |
@reidab I think maybe that shouldn't be config anymore. Since the consuming application is responsible now for when Something like:
If that is the case we need to update the README to remove @rwjblue thoughts? |
Just a heads up - we are using this to dynamically select which CSS gets loaded for our app, when we disable the suppressBrowserRender in fastboot when the app rehydrates the css vanishes as everything in {{head-layout}} gets removed. Not sure what the right name for this variable is but it most likely needs to stay around to prevent triggering a CSS reload. |
I have been running into this issue as well. If I do what @rondale-sc suggests (wrap the |
As of 0.4.0, the
suppressBrowserRender
option doesn't really do what it says on the tin. Since the instance-initializer no longer injects{{head-layout}}
, returning early from it doesn't actually suppress any rendering.The text was updated successfully, but these errors were encountered: