Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Engines support #23

Open
amk221 opened this issue May 2, 2017 · 2 comments
Open

Engines support #23

amk221 opened this issue May 2, 2017 · 2 comments

Comments

@amk221
Copy link

amk221 commented May 2, 2017

Curious what the thinking is on this?
thanks for any info

edit: currently I don't think it works

@knownasilya
Copy link

knownasilya commented Jul 12, 2017

Would love this too, currently, I get the following error:

Assertion failed: Error: Could not find module `dashboard/templates/head` imported from `dashboard/components/head-content`

I'm using this module indirectly via ember-page-title.
This happens probably because all of the content is defined in the app folder, where engines use addon. Creating an app/templates/head.hbs in the engine doesn't help.

@robclancy
Copy link

robclancy commented Dec 6, 2017

To get this working with ember-page-title I had to share 'headData' service with the engine. Also I have ember-page-title as a dependency in the engines package.json. Without using ember-page-title I believe you will need to add ember-cli-head as a dependency in there.

This might just all work on latest simply with the package as a dependency. I haven't tested as I only need this for ember-page-title at this stage.

Similar requirements to ember-cli/ember-page-title#112 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants