Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix workspace protocol to use caret to avoid unnecessary duplication #948

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix workspace protocol to use caret to avoid unnecessary duplication #948

wants to merge 1 commit into from

Conversation

SergeAstapov
Copy link
Contributor

@SergeAstapov SergeAstapov commented May 22, 2024 •
edited
Loading

@mansona I guess this is the reason why fastboot-express-middleware was not included in latest release https://github.com/ember-fastboot/ember-cli-fastboot/releases/tag/v4.1.5-ember-cli-fastboot

Closes #951

@mansona
Copy link
Member

mansona commented May 22, 2024

so to be honest I think there was too much stuff included in the last release 🤔 I didn't expect anything other than fastboot-app-server to be released since it's downstream from fastboot and ember-cli-fastboot

i didn't investigate since it was such a small issue I didn't think it mattered

@SergeAstapov SergeAstapov force-pushed the patch-2 branch 2 times, most recently from 0f38a1a to ce6e38a Compare May 22, 2024 14:02
@SergeAstapov
Copy link
Contributor Author

SergeAstapov commented May 22, 2024 •
edited
Loading

@mansona as far as I see, it publishes everything because release-plan pin dependencies to specific version (or maybe it's pnpm) when the package or it's dependencies within monorepo gets bumped/published.

because of the typo fixed in this PR, fastboot-express-middleware was not bumped and published in previous releases.
As a result, latest https://www.npmjs.com/package/ember-cli-fastboot?activeTab=code points to "fastboot": "4.1.5" and "fastboot-express-middleware": "4.1.2"

whereas https://www.npmjs.com/package/fastboot-express-middleware?activeTab=code points to "fastboot": "4.1.2" so we end up using mix of fastboot libraries.

@mansona pushed fix for pnpm-lock.yaml file to make CI happy.

@SergeAstapov SergeAstapov mentioned this pull request Sep 18, 2024
Open
@SergeAstapov SergeAstapov changed the title Fix workspace protocol for fastboot-express-middleware package Fix workspace protocol to use caret to avoid unnecessary duplication Oct 11, 2024
@SergeAstapov
Copy link
Contributor Author

@mansona this was updated according to discussion in #951

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unnecessary package duplication
2 participants
@SergeAstapov @mansona