Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Experimental Mode Rehydrate properly using modules for modern Ember #938

Open
mansona opened this issue May 2, 2024 · 2 comments

Comments

@mansona
Copy link
Member

mansona commented May 2, 2024

The way this render mode was implemented before was to inject a vendor file that monkey-patches Ember https://github.com/ember-fastboot/ember-cli-fastboot/blob/v4.1.2/packages/ember-cli-fastboot/vendor/experimental-render-mode-rehydrate.js

This really isn't the right way to do things with modern ember 🙈 we need to make sure that we're importing a module properly and possibly setting module-scope data to tell it to use the new render-mode and not rely on monkey-patching classes 👍

@josemarluedke
Copy link
Contributor

Is rehydration still experimental?

@mansona
Copy link
Member Author

mansona commented May 2, 2024

so the fact that it isn't backed into Ember using public APIs means that yes it is. There were a few blockers that held it back when it was being implemented and I think there was supposed to be an RFC that never got submitted.

I think it shouldn't be too hard to get over the line but it should go through the standards process of an RFC 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants