Skip to content

Commit d549345

Browse files
authored
Merge pull request #834 from ember-fastboot/update
Update using ember-cli-update and drop support for Node 10
2 parents 18d41f0 + 1520085 commit d549345

33 files changed

+2049
-1116
lines changed

.github/ci.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ jobs:
2525

2626
strategy:
2727
matrix:
28-
node-version: [14.x, 12.x, 10.x]
28+
node-version: [16.x, 14.x, 12.x]
2929
os: [ubuntu-latest, windows-latest]
3030

3131
steps:
@@ -53,7 +53,7 @@ jobs:
5353

5454
strategy:
5555
matrix:
56-
node-version: [14.x, 12.x, 10.x]
56+
node-version: [16.x, 14.x, 12.x]
5757
os: [ubuntu-latest, windows-latest]
5858

5959
steps:
@@ -74,7 +74,7 @@ jobs:
7474

7575
strategy:
7676
matrix:
77-
node-version: [14.x, 12.x, 10.x]
77+
node-version: [16.x, 14.x, 12.x]
7878
os: [ubuntu-latest, windows-latest]
7979

8080
steps:

packages/ember-cli-fastboot/.editorconfig

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44

55
root = true
66

7-
87
[*]
98
end_of_line = lf
109
charset = utf-8

packages/ember-cli-fastboot/.eslintignore

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,14 @@
88

99
# dependencies
1010
/bower_components/
11+
/node_modules/
1112

1213
# misc
1314
/coverage/
15+
!.*
16+
.eslintcache
1417

1518
# ember-try
1619
/.node_modules.ember-try/
20+
/bower.json.ember-try
21+
/package.json.ember-try
Lines changed: 20 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,20 @@
1+
'use strict';
2+
13
module.exports = {
24
root: true,
5+
parser: 'babel-eslint',
36
parserOptions: {
4-
ecmaVersion: 2017,
5-
sourceType: 'module'
7+
ecmaVersion: 2018,
8+
sourceType: 'module',
9+
ecmaFeatures: {
10+
legacyDecorators: true,
11+
},
612
},
7-
plugins: [
8-
'ember'
9-
],
13+
plugins: ['ember'],
1014
extends: [
1115
'eslint:recommended',
12-
'plugin:ember/recommended'
16+
'plugin:ember/recommended',
17+
'plugin:prettier/recommended',
1318
],
1419
env: {
1520
browser: true
@@ -18,10 +23,14 @@ module.exports = {
1823
'ember/no-get': 'warn',
1924
'ember/require-computed-property-dependencies': 'warn'
2025
},
26+
rules: {},
2127
overrides: [
2228
// node files
2329
{
2430
files: [
31+
'.eslintrc.js',
32+
'.prettierrc.js',
33+
'.template-lintrc.js',
2534
'ember-cli-build.js',
2635
'index.js',
2736
'testem.js',
@@ -34,28 +43,18 @@ module.exports = {
3443
'app/**',
3544
'addon/**',
3645
'addon-test-support/**',
46+
'app/**',
47+
'tests/dummy/app/**',
3748
],
3849
parserOptions: {
3950
sourceType: 'script',
40-
ecmaVersion: 2015
4151
},
4252
env: {
4353
browser: false,
44-
node: true
54+
node: true,
4555
},
4656
plugins: ['node'],
47-
rules: Object.assign({}, require('eslint-plugin-node').configs.recommended.rules, {
48-
// add your custom rules and overrides for node files here
49-
})
57+
extends: ['plugin:node/recommended'],
5058
},
51-
52-
// test files
53-
{
54-
files: ['tests/**/*.js'],
55-
excludedFiles: ['tests/dummy/**/*.js'],
56-
env: {
57-
embertest: true
58-
}
59-
}
60-
]
59+
],
6160
};
Lines changed: 32 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,35 @@
1-
/bower_components
1+
# compiled output
2+
/dist/
3+
/tmp/
4+
5+
# dependencies
6+
/bower_components/
7+
8+
# misc
9+
/.bowerrc
10+
/.editorconfig
11+
/.ember-cli
12+
/.env*
13+
/.eslintcache
14+
/.eslintignore
15+
/.eslintrc.js
16+
/.git/
17+
/.gitignore
18+
/.prettierignore
19+
/.prettierrc.js
20+
/.template-lintrc.js
21+
/.travis.yml
22+
/.watchmanconfig
23+
/bower.json
224
/config/ember-try.js
3-
/dist
4-
/test
5-
/tests
6-
/tmp
7-
**/.gitkeep
8-
.bowerrc
9-
.editorconfig
10-
.ember-cli
11-
.eslintrc.js
12-
.gitignore
13-
.watchmanconfig
14-
.travis.yml
15-
bower.json
16-
ember-cli-build.js
17-
testem.js
18-
yarn.lock
25+
/CONTRIBUTING.md
26+
/ember-cli-build.js
27+
/testem.js
28+
/tests/
29+
/yarn.lock
30+
.gitkeep
1931

2032
# ember-try
21-
.node_modules.ember-try/
22-
bower.json.ember-try
23-
package.json.ember-try
33+
/.node_modules.ember-try/
34+
/bower.json.ember-try
35+
/package.json.ember-try
Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
# unconventional js
2+
/blueprints/*/files/
3+
/vendor/
4+
5+
# compiled output
6+
/dist/
7+
/tmp/
8+
9+
# dependencies
10+
/bower_components/
11+
/node_modules/
12+
13+
# misc
14+
/coverage/
15+
!.*
16+
.eslintcache
17+
18+
# ember-try
19+
/.node_modules.ember-try/
20+
/bower.json.ember-try
21+
/package.json.ember-try
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
'use strict';
2+
3+
module.exports = {
4+
singleQuote: true,
5+
};
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
'use strict';
2+
3+
module.exports = {
4+
extends: 'octane',
5+
};
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
'use strict';
22

3-
module.exports = function(/* environment, appConfig */) {
4-
return { };
3+
module.exports = function (/* environment, appConfig */) {
4+
return {};
55
};

packages/ember-cli-fastboot/ember-cli-build.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
const EmberAddon = require('ember-cli/lib/broccoli/ember-addon');
44

5-
module.exports = function(defaults) {
5+
module.exports = function (defaults) {
66
let app = new EmberAddon(defaults, {
77
// Add options here
88
});
@@ -14,5 +14,6 @@ module.exports = function(defaults) {
1414
behave. You most likely want to be modifying `./index.js` or app's build file
1515
*/
1616

17-
return app.toTree();
17+
const { maybeEmbroider } = require('@embroider/test-setup');
18+
return maybeEmbroider(app);
1819
};

0 commit comments

Comments
 (0)