Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple meta tags inserted into head-footer when multiple addons use ManifestGenerator #77

Open
brettburley opened this issue Feb 23, 2019 · 1 comment

Comments

@brettburley
Copy link

When an application has more than one ember addon installed that exports a ManifestGenerator-extended addon, a meta tag is inserted into the head-footer content-for block because each addon has a contentFor hook defined by ManifestGenerator:

contentFor: function(type, config) {

For example, with two addons that use ManifestGenerator, before post-processing, the index.html may look like:

<meta name="my-app/config/asset-manifest" content="%GENERATED_ASSET_MANIFEST%">
<meta name="my-app/config/asset-manifest" content="%GENERATED_ASSET_MANIFEST%">

After post-processing, the first meta tag is replaced by the contents of the asset manifests provided by both addons, so it has all of the correct content, but there is an extraneous meta tag that remains:

<meta name="my-app/config/asset-manifest" content="%7B%22bundles%22%3A%7B%22...">
<meta name="my-app/config/asset-manifest" content="%GENERATED_ASSET_MANIFEST%">

Ideally even if multiple addons consumed by the host app are using ManifestGenerator, only a single asset-manifest meta tag would be inserted, or the extra ones be removed during the post-processing when the manifest is being injected.

@evanfarina
Copy link
Contributor

I am seeing this as well. I have tested with both an in-repo addon and an external addon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants