-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Need file order in configuration. #37
Comments
Can you provide an example of what you mean and why this matters? The asset-manifest shouldn't care about order, since it is a map and not an array, and is generated from the filesystem, which means that collisions should be impossible. |
The manifest itself doesn't care about its order, but we use the order from the manifest for DOM insertion order. This is an example of the point at which it starts to matter, a folder consisting of:
Those will both be listed inside of the bundle, but we care about the order in which they appear in the document. We currently luck out that This config will need to be passable into the addon this addon provides. |
One could argue (not sure if I would at this moment in time) that within a given bundle, order should not matter. If order does matter, then those files should be concatenated in the proper order. That way, order then only matters between bundles, which I think becomes a much more tractable problem as far as API design is concerned. |
If you wish to create separate files for caching reasons manual concatenation makes less sense–which is the reason for the split of |
I'm also running into this between engine.css and engine-vendor.css because of fingerprinting swaps the order of the assets array. To work around this, I've reimplemented Ideally, this would be configurable at the engine level feeding the result to the host app. If I come up with anything, I'll send a PR. |
@jasonmit can you send the PR, please? I would love to see this |
We cannot simply rely on file name lexicographic ordering from broccoli-funnel for generating the asset manifest.
Since
ember-asset-loader
respects the ordering in terms of insertion order (which matters) we need to provide a way to configure file order.The text was updated successfully, but these errors were encountered: