Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import * as run '@ember/runloop' escapes ember/no-runloop rule #2263

Open
chancancode opened this issue Feb 14, 2025 · 0 comments
Open

import * as run '@ember/runloop' escapes ember/no-runloop rule #2263

chancancode opened this issue Feb 14, 2025 · 0 comments

Comments

@chancancode
Copy link

import { later } from '@ember/runloop'`

later(...); // bad!
import * as run from '@ember/runloop'`

run.later(...); // sure, no problem :)

I was essentially re-implementing something akin to ember-lifeline, so I was intentionally integrating with the ember runloop for test waiters. I was going to turn off this rules for that file, but after some refactoring eslint told me the comment wasn't necessary. Turns out the rule doesn't care about namespace import.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant