Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blueprint should remove <title> tag from app/index.html if Fastboot is present #174

Closed
raido opened this issue Sep 23, 2020 · 0 comments · Fixed by #177
Closed

Blueprint should remove <title> tag from app/index.html if Fastboot is present #174

raido opened this issue Sep 23, 2020 · 0 comments · Fixed by #177

Comments

@raido
Copy link
Contributor

raido commented Sep 23, 2020

ember-cli-fastboot blueprint will/should be updated - so that upon install default index.html <title> is replaced as title in application.hbs. Basically for Fastboot requirements about title element removal are the same that are already in README of this repository.

I think both blueprints (ember-cli-fastboot and ember-page-title) could do the check to see if both ember-cli-fastboot and ember-page-title are present and if so remove the <title></title> from app/index.html.

Mind making a meta issue for that here, and cross linking in an issue in ember-cli-fastboot?

Originally posted by @rwjblue in #168 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant