-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove dependency on ember-cli-head #167
Comments
Any tips on how to approach this? Manually update the title? |
What about fastboot? 🤔 |
@knownasilya that's a good question- I'm going to try to look at it today, but maybe @rwjblue has some advice if he can get to it before me. |
We don't need ember-cli-head in order to support FastBoot. The scenarios that we need to care about are:
Both of the client side renders can be accommodated by manipulating The server side render can be manipulated by setting let document = owner.lookup('service:-document');
let titleEl = document.createElement('title');
let titleContents = document.createTextNode('whatever the title contents should be');
titleEl.appendChild(titleContents);
document.head.appendChild(titleEl); |
For more context, the |
Just letting know that I am experimenting implementing this. Having some Fastboot issues for few test cases. If I cannot resolve them I'll open draft PR for help. |
Here's a draft PR - #168 |
TODO: Change
ember-page-title
to remove theember-cli-head
requirement (for both SSR and in browser)Teams will have to add the ember-cli-head addon if they want the functionality from both.
This will unblock the related RFC
We'll need to create a new release and do a major version bump.
Notes:
After this is finished, update RFC 645 to add both ember-page-title and ember-cli-head as dev dependencies of apps.
The text was updated successfully, but these errors were encountered: