Upgrade to Ember v3.20, drop Node 8 (#170)

* Upgrade to Ember.js v3.20, drop Node 8

* Fix ESLint issues

* Fix failing tests

* Switch template-lint back to 'recommended' for now

* Fix dummy app errors from before already

* Update ember-cli-code-coverage to latest

* Fix missing await in tests

Author: raido

.editorconfig

@@ -4,7 +4,6 @@
 
 root = true
 
-
 [*]
 end_of_line = lf
 charset = utf-8

.eslintrc.js

@@ -1,13 +1,19 @@
+'use strict';
+
 module.exports = {
   root: true,
+  parser: 'babel-eslint',
   parserOptions: {
     ecmaVersion: 2018,
     sourceType: 'module',
+    ecmaFeatures: {
+      legacyDecorators: true
+    }
   },
   plugins: ['ember'],
   extends: ['eslint:recommended', 'plugin:ember/recommended'],
   env: {
-    browser: true,
+    browser: true
   },
   rules: {},
   overrides: [
@@ -31,21 +37,14 @@ module.exports = {
         'tests/dummy/app/**',
       ],
       parserOptions: {
-        sourceType: 'script',
-        ecmaVersion: 2015,
+        sourceType: 'script'
       },
       env: {
         browser: false,
         node: true,
       },
       plugins: ['node'],
-      rules: Object.assign(
-        {},
-        require('eslint-plugin-node').configs.recommended.rules,
-        {
-          // add your custom rules and overrides for node files here
-        }
-      ),
-    },
-  ],
+      extends: ['plugin:node/recommended']
+    }
+  ]
 };

.npmignore

@@ -12,6 +12,7 @@
 /.env*
 /.eslintignore
 /.eslintrc.js
+/.git/
 /.gitignore
 /.template-lintrc.js
 /.travis.yml

.template-lintrc.js

@@ -1,5 +1,5 @@
 'use strict';
 
 module.exports = {
-  extends: 'recommended'
+  extends: 'recommended' // TODO migrate to "octane"
 };

.travis.yml

@@ -3,10 +3,9 @@ language: node_js
 node_js:
   # we recommend testing addons with the same minimum supported node version as Ember CLI
   # so that your addon works for all apps
-  - "8"
+  - "10"
 
-sudo: false
-dist: trusty
+dist: xenial
 
 addons:
   chrome: stable
@@ -22,29 +21,34 @@ env:
     - CC_TEST_REPORTER_ID=f1b6bcc83789c103f7822eb2ec34bbdc34be1b36bdc66bc6de53c26ed1a14e27
 
 jobs:
-  fail_fast: true
+  fast_finish: true
   allow_failures:
     - env: EMBER_TRY_SCENARIO=ember-canary
 
   include:
     # runs linting and tests with current locked deps
-
     - stage: "Tests"
       name: "Tests"
       script:
-        - npm run lint:hbs
-        - npm run lint:js
-        - npm test
+        - npm run lint
+        - npm run test:ember
+
+    - stage: "Additional Tests"
+      name: "Floating Dependencies"
+      install:
+        - npm install --no-package-lock
+      script:
+        - npm run test:ember
 
     # we recommend new addons test the current and previous LTS
     # as well as latest stable release (bonus points to beta/canary)
-    - stage: "Additional Tests"
-      env: EMBER_TRY_SCENARIO=ember-lts-2.18
-    - env: EMBER_TRY_SCENARIO=ember-lts-3.4
+    - env: EMBER_TRY_SCENARIO=ember-lts-3.12
+    - env: EMBER_TRY_SCENARIO=ember-lts-3.16
     - env: EMBER_TRY_SCENARIO=ember-release
     - env: EMBER_TRY_SCENARIO=ember-beta
     - env: EMBER_TRY_SCENARIO=ember-canary
     - env: EMBER_TRY_SCENARIO=ember-default-with-jquery
+    - env: EMBER_TRY_SCENARIO=ember-classic
 
 before_script:
   - curl -L https://codeclimate.com/downloads/test-reporter/test-reporter-latest-linux-amd64 > ./cc-test-reporter

CONTRIBUTING.md

@@ -23,4 +23,4 @@
 * `ember serve`
 * Visit the dummy application at [http://localhost:4200](http://localhost:4200).
 
-For more information on using ember-cli, visit [https://ember-cli.com/](https://ember-cli.com/).
+For more information on using ember-cli, visit [https://ember-cli.com/](https://ember-cli.com/).

LICENSE.md

@@ -1,6 +1,6 @@
 The MIT License (MIT)
 
-Copyright (c) 2017
+Copyright (c) 2020
 
 Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
 

README.md

@@ -13,6 +13,12 @@ Add `{{head-layout}}` to your application's `application.hbs` template.
 <details>
 <summary>Fastboot vs Non-Fastboot Notes</summary>
 
+### Compatibility
+
+* Ember.js v3.12 or above
+* Ember CLI v2.13 or above
+* Node.js v10 or above
+
 #### Post Install Cleanup
 
 As of v3.0.0 this addon maintains the page title by using the `<title>` tag in your document's `<head>`. This is necessary for [FastBoot](https://github.com/tildeio/ember-cli-fastboot) compatibility.

addon/helpers/page-title.js

@@ -1,7 +1,7 @@
 import { scheduleOnce } from '@ember/runloop';
 import { inject as service } from '@ember/service';
 import Helper from '@ember/component/helper';
-import { set, get } from '@ember/object';
+import { set } from '@ember/object';
 import { guidFor } from '@ember/object/internals';
 import { assign } from '@ember/polyfills';
 import { getOwner } from '@ember/application';
@@ -22,7 +22,7 @@ export default Helper.extend({
 
   init() {
     this._super();
-    let tokens = get(this, 'pageTitleList');
+    let tokens = this.pageTitleList;
     tokens.push({ id: guidFor(this) });
   },
 
@@ -35,24 +35,24 @@ export default Helper.extend({
           _hash._deprecate
       );
     }
-    let tokens = get(this, 'pageTitleList');
+    let tokens = this.pageTitleList;
     let hash = assign({}, _hash);
     hash.id = guidFor(this);
     hash.title = params.join('');
     tokens.push(hash);
-    scheduleOnce('afterRender', get(this, 'headData'), updateTitle, tokens);
+    scheduleOnce('afterRender', this.headData, updateTitle, tokens);
     return '';
   },
 
   destroy() {
-    let tokens = get(this, 'pageTitleList');
+    let tokens = this.pageTitleList;
     let id = guidFor(this);
     tokens.remove(id);
 
     let router = getOwner(this).lookup('router:main');
     let routes = router._routerMicrolib || router.router;
     let { activeTransition } = routes || {};
-    let headData = get(this, 'headData');
+    let headData = this.headData;
     if (activeTransition) {
       activeTransition.promise.finally(function () {
         if (headData.isDestroyed) {

addon/services/page-title-list.js

@@ -1,7 +1,7 @@
 import { A } from '@ember/array';
 import { getOwner } from '@ember/application';
 import Service from '@ember/service';
-import { set, get, computed } from '@ember/object';
+import { set, computed } from '@ember/object';
 import { copy } from 'ember-copy';
 import { capitalize } from '@ember/string';
 import { isPresent } from '@ember/utils';
@@ -54,9 +54,9 @@ export default Service.extend({
   tokens: null,
 
   applyTokenDefaults(token) {
-    let defaultSeparator = get(this, "defaultSeparator");
-    let defaultPrepend = get(this, "defaultPrepend");
-    let defaultReplace = get(this, "defaultReplace");
+    let defaultSeparator = this.defaultSeparator;
+    let defaultPrepend = this.defaultPrepend;
+    let defaultReplace = this.defaultReplace;
 
     if (token.separator == null) {
       token.separator = defaultSeparator;
@@ -112,7 +112,7 @@ export default Service.extend({
     let tokens = copy(this.tokens);
     tokens.push(token);
     set(this, 'tokens', A(tokens));
-    set(this, 'length', get(this, 'length') + 1);
+    set(this, 'length', this.length + 1);
   },
 
   remove(id) {
@@ -131,12 +131,12 @@ export default Service.extend({
     let tokens = A(copy(this.tokens));
     tokens.removeObject(token);
     set(this, 'tokens', A(tokens));
-    set(this, 'length', get(this, 'length') - 1);
+    set(this, 'length', this.length - 1);
   },
 
   visibleTokens: computed('tokens', {
     get() {
-      let tokens = get(this, 'tokens');
+      let tokens = this.tokens;
       let i = (tokens ? tokens.length : 0);
       let visible = [];
       while (i--) {
@@ -154,7 +154,7 @@ export default Service.extend({
 
   sortedTokens: computed('visibleTokens', {
     get() {
-      let visible = get(this, 'visibleTokens');
+      let visible = this.visibleTokens;
       let appending = true;
       let group = [];
       let groups = A([group]);
@@ -191,7 +191,7 @@ export default Service.extend({
   }),
 
   toString() {
-    let tokens = get(this, 'sortedTokens');
+    let tokens = this.sortedTokens;
     let title = [];
     for (let i = 0, len = tokens.length; i < len; i++) {
       let token = tokens[i];