Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New leaderboard filtering cross-encoders #1841

Open
Muennighoff opened this issue Jan 20, 2025 · 6 comments
Open

New leaderboard filtering cross-encoders #1841

Muennighoff opened this issue Jan 20, 2025 · 6 comments
Labels
leaderboard issues related to the leaderboard

Comments

@Muennighoff
Copy link
Contributor

Old LB has the ability to filter out CEs which is mostly relevant for w/ Instructions

@Samoed Samoed added the leaderboard issues related to the leaderboard label Jan 20, 2025
@x-tabdeveloping
Copy link
Collaborator

We should probably annotate this somehow in the model metadata. Perhaps add it as a framework?
Btw I might be using the filters wrong, but it doesn't seem to me that the cross-encoders button works as intended on the old leaderboard. If I only select that one, nothing shows up, if I select that and Open a lot of models show up that are not cross-encoders, and even some non-open ones.

Image

@Samoed
Copy link
Collaborator

Samoed commented Jan 21, 2025

I think we can add an is_cross_encoder field to the model meta. The approach with the framework wouldn’t work, as most of them are using Sentence Transformers.

@x-tabdeveloping
Copy link
Collaborator

Yeah but I imagine you could add frameworks=["Sentence Transformers", "Cross Encoders"] and then you would know that they are sentence-transformer compatible.
is_cross_encoder is not a bad idea either, we could totally do that.

@Samoed
Copy link
Collaborator

Samoed commented Jan 21, 2025

We have some reranking models that don't use Sentence Transformers, and since there's no framework specifically called CrossEncoders, it can be a bit confusing.

class MonoBERTReranker(RerankerWrapper):

@x-tabdeveloping
Copy link
Collaborator

Alright, we do it that way then

@sam-hey
Copy link
Contributor

sam-hey commented Jan 26, 2025

As mentioned in #1869 (comment), I suggest developing a more general method that is not limited to Cross-Encoders but can also be applied to other model categories, such as Late Interaction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
leaderboard issues related to the leaderboard
Projects
None yet
Development

No branches or pull requests

4 participants