Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post Production Migration Tasks #483

Open
4 of 15 tasks
jessykate opened this issue Mar 7, 2019 · 4 comments
Open
4 of 15 tasks

Post Production Migration Tasks #483

jessykate opened this issue Mar 7, 2019 · 4 comments

Comments

@jessykate
Copy link
Member

jessykate commented Mar 7, 2019

  • Purge hard coded media URLs in RoomDetail.jsx, location emails, and other @bfirsh Fix things which assume media is on server #488
  • distribute tarsnap keys
  • delete database dump from S3
  • 2FA all the things
    • Heroku
    • GitHub
    • Cloudflare
    • Mailgun
  • charging card gives error "card was declined" but the charge actually goes through. (turns out this is a template error) Fix custom email templates #530
  • add fake email sending to browser tests (would have caught above error) (unit test added in Fix custom email templates #530, which is probably good enough)
  • editing rate gives an error
  • click around more in manage pages
  • turn down alfred (eventually)
  • update email associated with stripe
  • update email associated with mailgun
bfirsh added a commit to bfirsh/modernomad that referenced this issue Mar 7, 2019
@jonathan-s
Copy link
Collaborator

jonathan-s commented Mar 7, 2019

add fake email sending to browser tests (would have caught above error)

This is kind of tricky. It would mean that we would need to supply the api key for mailgun in clear text basically, which means it could be abused. I think the better answer is to write unit tests for the views..

@bfirsh
Copy link
Member

bfirsh commented Mar 7, 2019

@jonathan-s sorry these were not verbose enough. We mean just rendering the template for the email, even when emails are disabled. A bug in the email template broke approving bookings.

@jonathan-s
Copy link
Collaborator

@bfirsh Right :). Well, that should be solved by the anymail branch ;). It renders the email templates and outputs those into console. So if there was template error that branch should have caught that as far as I understand.

jessykate pushed a commit that referenced this issue Mar 7, 2019
Notably, room and email images.

Ref #483
jessykate pushed a commit that referenced this issue Mar 8, 2019
Notably, room and email images.

Ref #483
@bfirsh
Copy link
Member

bfirsh commented Jul 20, 2019

@jessykate Did we get anywhere with these things? Deleting the database dump and setting up 2FA are the important things, I think. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants