Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to mark text as OOC in reader view #13

Open
fhemberger opened this issue Oct 10, 2018 · 4 comments
Open

Add option to mark text as OOC in reader view #13

fhemberger opened this issue Oct 10, 2018 · 4 comments

Comments

@fhemberger
Copy link
Contributor

It would be nice to have the opportunity to mark text inside a comment as "out of character".

@emanchado
Copy link
Owner

What kind of mark do you have in mind? Both how it would look visually, and how to trigger it.

I really don't want to add WYSIWYG controls or buttons or whatever, I'd prefer the messages to stay plain text. On the other hand, I don't oppose the idea of, say, highlighting lines starting OOC or similar.

@fhemberger
Copy link
Contributor Author

Maybe something as simple as text in square brackets gets a class "ooc". That should be enough. I'll come up with something.

@fhemberger
Copy link
Contributor Author

Okay, how about this: Replace square brackets with <span class=ooc>…</span> and use this simple style (just a quick draft).

.ooc::before {
    content: "OOC: "
}

.ooc {
    color:#cccc8d
}

Example:
bildschirmfoto 2018-10-12 um 09 48 25

@emanchado
Copy link
Owner

You mean that the original text (as written by the user) would be the one below?

[So maybe the female thief had something on her, ...]

When this is all over, ...

I'm highly sceptical, as I'd have to parse and find the closing bracket, it could span several lines, it could be mistaken by other stuff, etc.

What about marking with the class any line that starts with OOC:?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants