Skip to content

Commit 50889cb

Browse files
committed
Merge pull request #30 from tarsius/master
Stop using magit-insert
2 parents 484b284 + d914b75 commit 50889cb

File tree

1 file changed

+10
-14
lines changed

1 file changed

+10
-14
lines changed

magit-gerrit.el

Lines changed: 10 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -212,12 +212,10 @@ Succeed even if branch already exist
212212
(score (cdr-safe (assoc 'value approval))))
213213

214214
(magit-insert-section (section approval)
215-
(magit-insert (concat
216-
(magit-gerrit-pretty-print-reviewer
217-
approvname approvemail
218-
(when codereview score)
219-
(when verified score))
220-
"\n")))))
215+
(insert (magit-gerrit-pretty-print-reviewer approvname approvemail
216+
(and codereview score)
217+
(and verified score))
218+
"\n"))))
221219

222220
(defun magit-gerrit-wash-approvals (approvals)
223221
(mapc #'magit-gerrit-wash-approval approvals))
@@ -241,14 +239,12 @@ Succeed even if branch already exist
241239
(delete-region beg end))
242240
(when (and num subj owner-name)
243241
(magit-insert-section (section subj)
244-
(magit-insert
245-
(propertize
246-
(magit-gerrit-pretty-print-review num subj owner-name isdraft)
247-
'magit-gerrit-jobj
248-
jobj))
242+
(insert (propertize
243+
(magit-gerrit-pretty-print-review num subj owner-name isdraft)
244+
'magit-gerrit-jobj
245+
jobj))
249246
(unless (magit-section-hidden (magit-current-section))
250-
(magit-gerrit-wash-approvals approvs)
251-
)
247+
(magit-gerrit-wash-approvals approvs))
252248
(add-text-properties beg (point) (list 'magit-gerrit-jobj jobj)))
253249
t)))
254250

@@ -261,7 +257,7 @@ Succeed even if branch already exist
261257
(magit-insert-section (section title)
262258
(magit-insert-heading title)
263259
(magit-git-wash washer (split-string (car args)))
264-
(magit-insert "\n"))))
260+
(insert "\n"))))
265261

266262
(defun magit-gerrit-remote-update (&optional remote)
267263
nil)

0 commit comments

Comments
 (0)