Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lsp-ui-sideline pop message break line on emacs 29.0.60 #746

Open
liuchong opened this issue Mar 23, 2023 · 11 comments
Open

lsp-ui-sideline pop message break line on emacs 29.0.60 #746

liuchong opened this issue Mar 23, 2023 · 11 comments

Comments

@liuchong
Copy link
Contributor

The pop out alert message of lsp-ui-sideline added a line break, when move the cursor on and off the error code, the window will change.
It's annoying, just disable lsp-ui-sideline-mode is ok, maybe. 🔥

Normal:
image

Normal in small window:
image

Broken in wide window:
image

Disabled:
image

@liuchong liuchong changed the title lsp-ui-sideline pop message break line lsp-ui-sideline pop message break line on emacs 29.0.60 Mar 28, 2023
@Flinner
Copy link

Flinner commented Mar 31, 2023

Is this unsolved? #96

@liuchong
Copy link
Contributor Author

liuchong commented Apr 4, 2023

Is this unsolved? #96

I noticed that #96 is an old issue and seems was fixed, not sure if it is same problem as what I found, or maybe new version of emacs breaks it again? @Flinner
The difference of my issue and #96 is that is the real message breaks line, but this is not real message but only a small word references does it.

@ivan-avalos
Copy link

I'm experiencing this too with Emacs 29.0.91. It makes writing code very annoying, especially with Dart, since Dart has labels at the end of every nested structure, and while typing, lines are constantly jumping as sideline actions appear and disappear.

Screenshot_20230528_224945

@jcs090218
Copy link
Member

I don't know if this will work, but you can try sideline and sideline-lsp. Pretty much the improved version of lsp-ui-sideline.

@liuchong
Copy link
Contributor Author

There seems has similar problem in sideline-lsp, please check the below images:

Normal:
image
Sideline enabled:
image

@liuchong
Copy link
Contributor Author

I think the prompt message on the right should not effect the display of source codes on the left.

@jcs090218
Copy link
Member

Thanks for testing it out! I will investigate the bug. ;)

@liuchong
Copy link
Contributor Author

@jcs090218 hi, did you fixed it? 👀

@jcs090218
Copy link
Member

I have taken a closer look at the issue. It seems like it's a conflict with other overlays. 🤔

For sideline-lsp, you can try:

(setq sideline-backends-right-skip-current-line t)

There isn't a good solution yet since there isn't a good way to calculate all the overlays in the buffer/window. 😓

@liuchong
Copy link
Contributor Author

Maybe create another layer on top of the editing buffer when popping out the message? @jcs090218 👀

@jcs090218
Copy link
Member

jcs090218 commented Jul 14, 2023

Maybe create another layer on top of the editing buffer when popping out the message?

No, we already have lsp-ui-doc that does that. I don't think that will solve the issue, but making it customizable might be one solution (use different frontend). 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants