Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: re-arrange mode line order #2571

Open
alanz opened this issue Jan 30, 2021 · 6 comments · May be fixed by #3188
Open

Feature Request: re-arrange mode line order #2571

alanz opened this issue Jan 30, 2021 · 6 comments · May be fixed by #3188
Labels
enhancement

Comments

@alanz
Copy link
Contributor

alanz commented Jan 30, 2021

#2567 brought in a much-improved progress reporting widget.

But it highlighted for me a niggling issue. All the interesting stuff reported in the mode line by lsp-mode comes right at the end of the mode line, where for me most of the time it is invisible. (I use a fairly "vanilla" setup, tweaked slightly with the excellent blackout package to remove or shorten displayed items)

image

The legacy progress reporting modified the mode lighter, which is far to the left, so visible even when you have many windows open side by side. With the progress added to global-mode-string, it has moved to the end.

Perhaps we should consider moving the lsp-mode information to the left, between vc-info and mode info.

Using lsp-mode at: abac0d7
@ericdallo
Copy link
Member

Do you see any issues with that @yyoncho, also we could take the opportunity to fix that spacing issue in modeline (add space to the left instead of right, something like that)

@yyoncho
Copy link
Member

yyoncho commented Jan 30, 2021

I think that we should group all lsp-mode related modeline stuff in a separate variable(e. g. lsp-modeline-string) instead of using global-mode-string and then place it on the modeline probably before the major mode list similar to what evil-mode does(I guess there are other packages doing that). When we do so, we are much more in control to do the proper spacing because only lsp-mode will use that variable.

@yyoncho
Copy link
Member

yyoncho commented Jan 30, 2021

For reference, here it is mode-line-format on my side

("%e" mode-line-front-space mode-line-mule-info mode-line-client mode-line-modified mode-line-remote mode-line-frame-identification mode-line-buffer-identification "   " mode-line-position evil-mode-line-tag
 (vc-mode vc-mode)
 "  " mode-line-modes mode-line-misc-info mode-line-end-spaces)

global-mode-string goes in mode-line-misc-info

@ericdallo
Copy link
Member

Yeah this looks a good idea, doom-modeline does that similar

@yyoncho
Copy link
Member

yyoncho commented Jan 30, 2021

Yeah this looks a good idea, doom-modeline does that similar

doom-modeline will have to be fixed separately I guess.

@yyoncho
Copy link
Member

yyoncho commented Jan 30, 2021

FWIW until the issue is fixed one can use diminish package to clean the major/minor modes from the modeline.

@yyoncho yyoncho mentioned this issue Jul 6, 2021
Open
3 tasks
@wztdream wztdream mentioned this issue Jul 6, 2021
Closed
@ericdallo ericdallo linked a pull request Nov 5, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[modeline] Add segments to future drop global-mode-string emacs-lsp/lsp-mode
3 participants
@alanz @ericdallo @yyoncho