Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lsp-rename is broken #192

Open
hellwolf opened this issue Dec 21, 2024 · 4 comments
Open

lsp-rename is broken #192

hellwolf opened this issue Dec 21, 2024 · 4 comments

Comments

@hellwolf
Copy link

Step to reproduce,

  1. have any small project open.
  2. M-x lsp-rename
  3. Got: "lsp--range-to-region: Wrong type argument: hash-table-p, nil"
@kenranunderscore
Copy link

I'm running into the same, but know too little about how lsp-mode and lsp-haskell work under the hood to debug it myself I think.

@psibi
Copy link
Member

psibi commented Jan 17, 2025

I can confirm that this workaround works for me: emacs-lsp/lsp-mode#4473 (comment)

So setting this seems to make it work:

(use-package lsp-haskell
  :ensure t
  :after (haskell-mode)
  :custom
  (lsp-rename-use-prepare nil))

@kenranunderscore
Copy link

@psibi Awesome, works for me as well. I didn't even know about the existence of prepareRename before this.

@hellwolf
Copy link
Author

hmm, nice.

what should be the proper fix in the package?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants