Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1510 Context toolbar overflow menu is truncated at edge of viewport #1511

Merged
merged 32 commits into from
Jul 6, 2023

Conversation

tomlyn
Copy link
Member

@tomlyn tomlyn commented Jun 25, 2023

Fixes: #1510

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@tomlyn tomlyn self-assigned this Jun 25, 2023
Signed-off-by: CTomlyn <[email protected]>
Signed-off-by: CTomlyn <[email protected]>
Signed-off-by: CTomlyn <[email protected]>
Signed-off-by: CTomlyn <[email protected]>
Signed-off-by: CTomlyn <[email protected]>
tomlyn added 19 commits June 29, 2023 15:38
Signed-off-by: CTomlyn <[email protected]>
Signed-off-by: CTomlyn <[email protected]>
Signed-off-by: CTomlyn <[email protected]>
Signed-off-by: CTomlyn <[email protected]>
Signed-off-by: CTomlyn <[email protected]>
Signed-off-by: CTomlyn <[email protected]>
Signed-off-by: CTomlyn <[email protected]>
Signed-off-by: CTomlyn <[email protected]>
Signed-off-by: CTomlyn <[email protected]>
Signed-off-by: CTomlyn <[email protected]>
Signed-off-by: CTomlyn <[email protected]>
Signed-off-by: CTomlyn <[email protected]>
Signed-off-by: CTomlyn <[email protected]>
Signed-off-by: CTomlyn <[email protected]>
Signed-off-by: CTomlyn <[email protected]>
Signed-off-by: CTomlyn <[email protected]>
Signed-off-by: CTomlyn <[email protected]>
Signed-off-by: CTomlyn <[email protected]>
Signed-off-by: CTomlyn <[email protected]>
Signed-off-by: CTomlyn <[email protected]>
Signed-off-by: CTomlyn <[email protected]>
Signed-off-by: CTomlyn <[email protected]>
Copy link
Member

@caritaou caritaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see a warning when I leave the context menu
context toolbar warning

image

Signed-off-by: CTomlyn <[email protected]>
@tomlyn
Copy link
Member Author

tomlyn commented Jul 6, 2023

@caritaou I fixed both comments you made.

Signed-off-by: CTomlyn <[email protected]>
@tomlyn tomlyn merged commit 9659a8c into elyra-ai:main Jul 6, 2023
3 checks passed
@tomlyn tomlyn deleted the move_ct_menus branch July 6, 2023 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Context toolbar overflow menu is truncated at edge of viewport
2 participants