Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Auto-Arrange function of pipeline canvas #567

Open
romeokienzler opened this issue Mar 18, 2021 · 3 comments
Open

Improve Auto-Arrange function of pipeline canvas #567

romeokienzler opened this issue Mar 18, 2021 · 3 comments
Labels

Comments

@romeokienzler
Copy link
Member

Is your feature request related to a problem? Please describe.
Larger pipelines get overwhelmingly confusing. The auto-format feature then is not handy anymore as it arranges all nodes horizontally or vertically.

Describe the solution you'd like
Introduce a "line break" where nodes get arranged horizontally until a certain (configurable) with is reached, then it automatically starts in the next row and so on

Describe alternatives you've considered
Automatic horizontal arrangement of all elements, then move blocks around...

Additional context

@lresende
Copy link
Member

Please transfer this issue to the canvas repo.

@ptitzler ptitzler transferred this issue from elyra-ai/elyra Mar 18, 2021
@romeokienzler
Copy link
Member Author

@ptitzler mni tnx!

@tomlyn
Copy link
Member

tomlyn commented Mar 18, 2021

@lresende
Elyra canvas provides a basic horizontal (and a vertical) auto-arrange algorithm but more application specific auto-arrangements don't necessarily have to be implemented inside Elyra canvas. The host application, in this case Elyra, can calculate whatever x and y co-ordinates it wants for the nodes, based on its own layout algorithm, and then feed them to Elyra canvas either in the pipeline flow document or by calling the CanvasController API to set node positions individually.

The general guidance for adding function in to Elyra Canvas should be we add things:

  1. when a feature is required by more than one host app team
  2. when a feature cannot be implemented by a host app developer. e.g. direct manipulation gestures

So in this case, unless other teams want the exact same type of auto-arrange I think it should be implemented outside of Elyra Canvas.

@tomlyn tomlyn added the Canvas label Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants