Merge pull request #514 from chriskrycho/cleanup-perf

Performance: avoid creating callbacks for the destructor

Author: elwayman02

addon/modifiers/did-resize.js

@@ -30,11 +30,11 @@ export default class DidResizeModifier extends Modifier {
       });
     }
 
-    registerDestructor(this, (instance) => instance.unobserve());
+    registerDestructor(this, unobserve);
   }
 
   modify(element, positional /*, named*/) {
-    this.unobserve();
+    unobserve(this);
 
     this.element = element;
 
@@ -54,13 +54,6 @@ export default class DidResizeModifier extends Modifier {
     }
   }
 
-  unobserve() {
-    if (this.element && DidResizeModifier.observer) {
-      DidResizeModifier.observer.unobserve(this.element);
-      this.removeHandler();
-    }
-  }
-
   addHandler() {
     DidResizeModifier.handlers.set(this.element, this.handler);
   }
@@ -69,3 +62,14 @@ export default class DidResizeModifier extends Modifier {
     DidResizeModifier.handlers.delete(this.element);
   }
 }
+
+/**
+ *
+ * @param {DidResizeModifier} instance
+ */
+function unobserve(instance) {
+  if (instance.element && DidResizeModifier.observer) {
+    DidResizeModifier.observer.unobserve(instance.element);
+    instance.removeHandler();
+  }
+}