Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Come up with a good way to track upstream plugin versions #6

Open
ellenhp opened this issue Oct 27, 2023 · 1 comment
Open

Come up with a good way to track upstream plugin versions #6

ellenhp opened this issue Oct 27, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@ellenhp
Copy link
Owner

ellenhp commented Oct 27, 2023

Latest Bambu Studio will refuse to operate with this plugin because I haven't updated the version tag yet, which is such a bummer because I don't think the API has changed substantially. I see two options: Build a bunch of version tags in CI, or somehow pull out the expected version tag at runtime from the binary that dlopens the plugin. The version tag shows up in strings and has a pretty consistent format so we could just grep for it?

Alternatively, I could go to upstream and ask them to stop breaking things. If Prusa Slicer were LGPL or something I'd maybe understand this kind of behavior but it's not, it's AGPL, and if they're going to violate the AGPL by shipping a slicer that only functions with a closed-source plugin, the least they can do is stop breaking the interface.

@ellenhp ellenhp added the bug Something isn't working label Oct 27, 2023
@Kyon147
Copy link

Kyon147 commented Oct 27, 2023

grep'ing the string makes the most sense I think from an automated standpoint. Saves the mess of having to build a bunch of version tags each time and try and keep them in sync with what Bamboo expects for the slicer to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants