Skip to content

Commit 24676d6

Browse files
committed
improve code styles, ensure booleans correct
1 parent 1b4bebe commit 24676d6

File tree

1 file changed

+8
-7
lines changed

1 file changed

+8
-7
lines changed

lib/protobuf/decoder.ex

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -233,15 +233,16 @@ defmodule Protobuf.Decoder do
233233
%FieldProps{type: type, map?: map?, oneof: oneof, name_atom: name_atom, repeated?: repeated?} =
234234
prop
235235

236-
embedded_msg = decode(bin, type)
236+
embed_msg = decode(bin, type)
237237

238238
val =
239-
if map?,
240-
do: %{
241-
(embedded_msg.key || map_default(prop, :key)) =>
242-
embedded_msg.value || map_default(prop, :value)
243-
},
244-
else: embedded_msg
239+
if map? do
240+
key = if is_nil(embed_msg.key), do: map_default(prop, :key), else: embed_msg.key
241+
value = if is_nil(embed_msg.value), do: map_default(prop, :value), else: embed_msg.value
242+
%{key => value}
243+
else
244+
embed_msg
245+
end
245246

246247
val = if oneof, do: {name_atom, val}, else: val
247248

0 commit comments

Comments
 (0)